OTA-1272: pkg/cli/admin/upgrade/recommend: Add end-to-end output test coverage #1885
Conversation
Borrowing the framework from pkg/cli/admin/upgrade/status, so we can iterate on this tech-preview command without having to launch test-clusters to confirm we are getting the output we expect for covered situations.
openshift-ci-robot
added
the
jira/valid-reference
|
@wking: This pull request references OTA-1272 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-cli |
|
[ART PR BUILD NOTIFIER] Distgit: ose-tools |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-deployer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cli-artifacts |
When I added this option in db01005 (pkg/cli/admin/upgrade/recommend: Add end-to-end output test coverage, 2024-09-24, openshift#1885), I'd been planning on dropping it at GA. But given the current focus on testing, I'm going to keep it through GA. This commit hides the test-focused option, to avoid distracting end users with internal knobs they are unlikely to need access to.
4 participants
Borrowing the framework from
pkg/cli/admin/upgrade/status, so we can iterate on this tech-preview command without having to launch test-clusters to confirm we are getting the output we expect for covered situations. Preparatory work for OTA-1272.