Skip to content

[release-4.15] OCPBUGS-25016: Bump api to include the new CloudCredential cap #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Dec 12, 2023
Merged

[release-4.15] OCPBUGS-25016: Bump api to include the new CloudCredential cap #1623

openshift-merge-bot merged 2 commits into from
Dec 12, 2023

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 11, 2023

This is an automated cherry-pick of #1622

/assign fxierh

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2023
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-24834 has been cloned as Jira Issue OCPBUGS-25016. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-25016: Bump api to include the new CloudCredential cap

Details

In response to this:

This is an automated cherry-pick of #1622

/assign fxierh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-24834: Bump api to include the new CloudCredential cap [release-4.15] OCPBUGS-25016: Bump api to include the new CloudCredential cap Dec 11, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25016, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1622

/assign fxierh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from deads2k and mfojtik December 11, 2023 05:54
@fxierh
Copy link
Contributor

fxierh commented Dec 11, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2023

@fxierh: This pull request references Jira Issue OCPBUGS-25016, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24834 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-24834 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhouying7780 December 11, 2023 05:58
@fxierh
Copy link
Contributor

fxierh commented Dec 11, 2023

/retest

3 similar comments
@fxierh
Copy link
Contributor

fxierh commented Dec 11, 2023

/retest

@fxierh
Copy link
Contributor

fxierh commented Dec 11, 2023

/retest

@fxierh
Copy link
Contributor

fxierh commented Dec 11, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 91f9d3d link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fxierh
Copy link
Contributor

fxierh commented Dec 11, 2023

/cc @ardaguclu

Would you please help to approve this cherry-pick ? Thanks.

@openshift-ci openshift-ci bot requested a review from ardaguclu December 11, 2023 20:14
@zhouying7780
Copy link
Contributor

zhouying7780 commented Dec 12, 2023

Done pre-merge test , no issue found.

@zhouying7780
Copy link
Contributor

zhouying7780 commented Dec 12, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 12, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 12, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25016, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24834 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-24834 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

This is an automated cherry-pick of #1622

/assign fxierh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member

ardaguclu commented Dec 12, 2023

  • openshift/api bump looks reasonable
  • k8s(api, api-machinery) bump to 1.28.4 shouldn't be a problem

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@fxierh
Copy link
Contributor

fxierh commented Dec 12, 2023 •
edited
Loading

@ardaguclu Thanks. Can this get an backport-risk-assessed label as well ?

@fxierh
Copy link
Contributor

fxierh commented Dec 12, 2023

/cc @ingvagabund

@openshift-ci openshift-ci bot requested a review from ingvagabund December 12, 2023 07:18
@ingvagabund
Copy link
Member

ingvagabund commented Dec 12, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 12, 2023
@zhouying7780
Copy link
Contributor

zhouying7780 commented Dec 12, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 12, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 39acc2e into openshift:release-4.15 Dec 12, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 12, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-25016: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25016 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1622

/assign fxierh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 12, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.15.0-202312121223.p0.g39acc2e.assembly.stream for distgit openshift-enterprise-cli.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@ardaguclu ardaguclu

@xingxingxia xingxingxia

@evakhoni evakhoni

@fxierh fxierh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@openshift-cherrypick-robot @openshift-ci-robot @fxierh @zhouying7780 @ardaguclu @ingvagabund @openshift-bot @kasturinarra @xingxingxia @evakhoni