Skip to content

feat: add readyz for user informer sync #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ricardomaraschini wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Draft

feat: add readyz for user informer sync #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/oauth/apiserver/apiserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
tokenunion "k8s.io/apiserver/pkg/authentication/token/union"
"k8s.io/apiserver/pkg/registry/rest"
genericapiserver "k8s.io/apiserver/pkg/server"
"k8s.io/apiserver/pkg/server/healthz"
corev1 "k8s.io/client-go/kubernetes/typed/core/v1"
restclient "k8s.io/client-go/rest"
"k8s.io/client-go/tools/cache"
Expand Down Expand Up @@ -118,6 +119,11 @@ func (c completedConfig) New(delegationTarget genericapiserver.DelegationTarget)
return nil
}

// register a readyz check so the server will start reporting ready only when the user's informer has synced.
if err := s.GenericAPIServer.AddReadyzChecks(healthz.NewInformerSyncHealthz(c.ExtraConfig.UserInformers)); err != nil {
return nil, err
}

c.ExtraConfig.OAuthInformers = oauthinformer.NewSharedInformerFactory(oauthClient, defaultInformerResyncPeriod)
postStartHooks["openshift.io-StartOAuthInformer"] = func(ctx genericapiserver.PostStartHookContext) error {
go c.ExtraConfig.OAuthInformers.Start(ctx.Done())
Expand Down