Mount SSE-C Encryption file for the AWS plugin

[WafaAmr]

Is your feature request related to a problem? Please describe.
The AWS plugin supports Server-Side Encryption with Customer-Managed Keys.

For example:

apiVersion: velero.io/v1
kind: BackupStorageLocation
...
spec:
  provider: velero.io/aws
  config:
    ...
    serverSideEncryption: AES256
    # Specify the file that contains the SSE-C customer key to enable customer key encryption of the backups
    # stored in S3. The referenced file should contain a 32-byte string.
    customerKeyEncryptionFile: "/credentials/customer-key"

As stated in the AWS:BSL documentation, I can define a path to the encryption file. The question now, Where should I specify the name of the Secret object customer-key to be mounted inside the velero-pod?

"Error getting backup store for this location" backupLocation=velero-sample-1 controller=backup-sync error="rpc error: code = Unknown desc = provided customerKeyEncryptionFile does not exist: /credentials/customer-key: stat /credentials/customer-key: no such file or directory"

Describe the solution you'd like
Provide a way to specify the secret customer-key as followed in backupLocation credential.
Additional context
OpenShift version : 4.9.48
OADP-Operator version : 1.1.0

[kaovilai]

Thanks for filing issue!
Tracked in https://issues.redhat.com/browse/OADP-889

[kaovilai]

At least for internal image backup maybe blocked by distribution/distribution#3745

[kaovilai]

@WafaAmr is restic/restic#3612 (comment) a concern for you?
Affects restic backups.

[kaovilai]

So if this gets implemented it would be scoped to just manifests most likely.

[kaovilai]

Velero's restic, and future kopia uses encryption that are independent from storage provider specific implementations.

[WafaAmr]

Hey @kaovilai, thank you for you detailed response.
I'm currently looking for a way to encrypt all backup date (internal images, manifests, and Restic backup data) stored in the remote storage object.
Yes, Restic uses encryption, but anyone who has access to the bucket can decrypt all Restic backup data (source).

[WafaAmr]

I'm not sure if Kopia will encrypt everything (vmware-tanzu/velero#3218 (comment)). If it's the case, it would be much better than supporting vendor-specific implementations.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kaovilai]

/lifecycle frozen

[weshayutin]

SSE-C is working as documented in the aws plugin.
https://hackmd.io/nWTqKj4dRxiU3PCuAKtYuQ

[kaovilai]

For anyone reading this: you need to trigger oadp's secret mounting per known issues in the hackmd above.

Future enhancements will be after vmware-tanzu/velero#7767 is solved.