Skip to content

collection-scripts/gather: Add imagecontentsourcepolicies.operator.openshift.io#135

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:ImageContentSourcePolicies
Dec 11, 2019
Merged

collection-scripts/gather: Add imagecontentsourcepolicies.operator.openshift.io#135
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:ImageContentSourcePolicies

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Nov 8, 2019

@wking
collection-scripts/gather: Add imagecontentsourcepolicies.operator.op…
6cc95f8 
…enshift.io

Catching up with openshift/api@700fd891c4 (Add operator.openshift.io
from cluster-config-operator, 2019-10-07, openshift/api#470).
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2019
@abhinavdahiya
Copy link
Copy Markdown

abhinavdahiya commented Nov 8, 2019

MCO ecosystem acts on this object, so I think they should add it to the relatedObjects list and must-gather will get it.

@sferich888
Copy link
Copy Markdown
Contributor

sferich888 commented Nov 8, 2019

I agree. @wking can we close this in favor of related object in the mco?

@wking
Copy link
Copy Markdown
Member Author

wking commented Dec 9, 2019

MCO relatedObjects handling is broken at the moment, but is also hard to fix. I've filed rhbz#1780362 for that, but can we get this as a temporary stopgap?

@sferich888
Copy link
Copy Markdown
Contributor

sferich888 commented Dec 10, 2019

We need an issue/tracker to pull this out, when that BZ is resolved.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sferich888, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@wking
Copy link
Copy Markdown
Member Author

wking commented Dec 10, 2019

We need an issue/tracker to pull this out, when that BZ is resolved.

Filed.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 11, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a7a8182 into openshift:master Dec 11, 2019
@wking wking deleted the ImageContentSourcePolicies branch April 27, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RickJWagner RickJWagner Awaiting requested review from RickJWagner

@sferich888 sferich888 Awaiting requested review from sferich888

Assignees

@sferich888 sferich888

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wking @abhinavdahiya @sferich888 @openshift-ci-robot @openshift-bot @openshift-merge-robot