Skip to content

Migrate away from deprecated ioutil - #80

Closed
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:ioutil_deprecation
Closed

Migrate away from deprecated ioutil#80
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:ioutil_deprecation

Conversation

@sebrandon1

Copy link
Copy Markdown
Member

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Test code modernization:

  • Replaced ioutil.TempDir with os.MkdirTemp for creating temporary directories in test setup.
  • Replaced ioutil.WriteFile with os.WriteFile for writing test rule files in multiple test cases. [1] [2] [3] [4]
  • Removed the unused import of ioutil from the test file.

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

@openshift-ci
openshift-ci Bot requested review from bpickard22 and pliurh November 24, 2025 17:18
@openshift-ci

openshift-ci Bot commented Nov 24, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign zshi-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Nov 24, 2025

Copy link
Copy Markdown

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 1350806 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SchSeba

SchSeba commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2025
@SchSeba

SchSeba commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

lets wait and check the new nftable implementation #77
if we still need to fix that please do it on the u/s repo first https://github.com/k8snetworkplumbingwg/multi-networkpolicy-nftables

@SchSeba

SchSeba commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

closing this one. as this repo must but a d/s sync only from the upstream repo

/close

@openshift-ci openshift-ci Bot closed this Dec 2, 2025
@openshift-ci

openshift-ci Bot commented Dec 2, 2025

Copy link
Copy Markdown

@SchSeba: Closed this PR.

Details

In response to this:

closing this one. as this repo must but a d/s sync only from the upstream repo

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sebrandon1

Copy link
Copy Markdown
Member Author

Sounds good! I'll take a look at the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants