Skip to content

Split mDNS service in host resolver, and route resolver #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mangelajo wants to merge 1 commit into from
Closed

Split mDNS service in host resolver, and route resolver #500

mangelajo wants to merge 1 commit into from

Conversation

@mangelajo
Copy link
Contributor

@mangelajo mangelajo commented Dec 13, 2021

The mDNS services are now split in route announcer and host
announcer, in such way that worker nodes can still announce
their names, but they won't announce routes.

Signed-off-by: Miguel Angel Ajo [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from mangelajo after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from fzdarsky and sallyom December 13, 2021 14:18
@mangelajo mangelajo requested a review from oglok December 13, 2021 15:00
@mangelajo mangelajo mentioned this pull request Dec 13, 2021
Closed
@cooktheryan
Copy link
Contributor

cooktheryan commented Dec 16, 2021

@mangelajo if you wanna resolve the conflicts we can run this back through testing

@mangelajo
Split mDNS service in host resolver, and route resolver
440abc6 
The mDNS services are now split in route announcer and host
announcer, in such way that worker nodes can still announce
their names, but they won't announce routes.

Signed-off-by: Miguel Angel Ajo <[email protected]>
@mangelajo
Copy link
Contributor Author

mangelajo commented Jan 14, 2022

Getting back to speed... I rebased and conflict-handled ':)

@mangelajo
Copy link
Contributor Author

mangelajo commented Jan 17, 2022

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

@mangelajo: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test test-srpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-openshift-conformance-sig-api-machinery
  • /test e2e-openshift-conformance-sig-apps
  • /test e2e-openshift-conformance-sig-arch
  • /test e2e-openshift-conformance-sig-auth
  • /test e2e-openshift-conformance-sig-cli
  • /test e2e-openshift-conformance-sig-instrumentation
  • /test e2e-openshift-conformance-sig-network
  • /test e2e-openshift-conformance-sig-node
  • /test e2e-openshift-conformance-sig-scheduling
  • /test e2e-openshift-conformance-sig-storage
  • /test e2e-reboot
  • /test e2e-rpm-install

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-api-machinery
  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-apps
  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-arch
  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-auth
  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-cli
  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-instrumentation
  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-network
  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-node
  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-scheduling
  • pull-ci-redhat-et-microshift-main-e2e-openshift-conformance-sig-storage
  • pull-ci-redhat-et-microshift-main-e2e-reboot
  • pull-ci-redhat-et-microshift-main-e2e-rpm-install
  • pull-ci-redhat-et-microshift-main-images
  • pull-ci-redhat-et-microshift-main-test-unit
  • pull-ci-redhat-et-microshift-main-verify
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mangelajo
Copy link
Contributor Author

mangelajo commented Jan 17, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2022

@mangelajo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-srpm ca42715171f78141fa3f9289ca1a29d943aafb01 link true /test test-srpm
ci/prow/e2e-rpm-install 440abc6 link false /test e2e-rpm-install
ci/prow/periodics-images 440abc6 link true /test periodics-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented May 18, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2022

@mangelajo: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

openshift-bot commented Jun 17, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 17, 2022
@mangelajo mangelajo closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fzdarsky fzdarsky Awaiting requested review from fzdarsky

@sallyom sallyom Awaiting requested review from sallyom

@oglok oglok Awaiting requested review from oglok

Assignees

No one assigned

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mangelajo @cooktheryan @openshift-bot