-
Notifications
You must be signed in to change notification settings - Fork 223
[WIP] Change kubeconfigs to point to the host IP #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ricardo Noriega <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I'm now thinking about the case where the device is restarted and the IP address changes due to a dhcp renewal. MicroShift will keep the host IP in the kubeconfigs and it'll crash. Would that work with microshift.cluster.local using mDNS? @mangelajo |
|
@oglok: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
what about using a name in the kubeconfigs? That way if the DHCP address changes the name should get patched as well. I think it would net us more possibilities for customers in the event that the facility in which microshift was running has some sort of VPN back to a home base a users could then load the kubeconfig into Argo and app of apps if they wanted |
yes, mDNS would handle this, via microshift.local or hostname.local etc .. :) |
|
included in #471 |
Signed-off-by: Ricardo Noriega [email protected]