Skip to content

Conversation

@oglok
Copy link
Contributor

@oglok oglok commented Nov 17, 2021

Signed-off-by: Ricardo Noriega [email protected]

@openshift-ci openshift-ci bot requested a review from fzdarsky November 17, 2021 12:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from oglok after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from mangelajo November 17, 2021 12:49
@oglok oglok changed the title Change kubeconfigs to point to the host IP [WIP] Change kubeconfigs to point to the host IP Nov 17, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2021
@oglok
Copy link
Contributor Author

oglok commented Nov 17, 2021

I'm now thinking about the case where the device is restarted and the IP address changes due to a dhcp renewal. MicroShift will keep the host IP in the kubeconfigs and it'll crash.

Would that work with microshift.cluster.local using mDNS? @mangelajo

@oglok oglok linked an issue Nov 17, 2021 that may be closed by this pull request
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@oglok: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-node d4d31d5 link false /test e2e-openshift-conformance-sig-node
ci/prow/e2e-openshift-conformance-sig-cli d4d31d5 link false /test e2e-openshift-conformance-sig-cli
ci/prow/e2e-openshift-conformance-sig-apps d4d31d5 link false /test e2e-openshift-conformance-sig-apps
ci/prow/e2e-openshift-conformance-sig-storage d4d31d5 link false /test e2e-openshift-conformance-sig-storage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cooktheryan
Copy link
Contributor

what about using a name in the kubeconfigs? That way if the DHCP address changes the name should get patched as well. I think it would net us more possibilities for customers in the event that the facility in which microshift was running has some sort of VPN back to a home base a users could then load the kubeconfig into Argo and app of apps if they wanted

@mangelajo
Copy link
Contributor

I'm now thinking about the case where the device is restarted and the IP address changes due to a dhcp renewal. MicroShift will keep the host IP in the kubeconfigs and it'll crash.

Would that work with microshift.cluster.local using mDNS? @mangelajo

yes, mDNS would handle this, via microshift.local or hostname.local etc .. :)

@mangelajo
Copy link
Contributor

included in #471

@mangelajo mangelajo closed this Dec 2, 2021
@cooktheryan cooktheryan deleted the mn-configs branch December 2, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants