Skip to content

rebase 4.14.0 + fix for router assets' source path #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 8 commits into from
Jul 27, 2023
Merged

rebase 4.14.0 + fix for router assets' source path #2122

openshift-merge-robot merged 8 commits into from
Jul 27, 2023

Conversation

@pmtk
Copy link
Member

@pmtk pmtk commented Jul 26, 2023 •
edited
Loading

@openshift-ci openshift-ci bot requested review from jogeo and pacevedom July 26, 2023 07:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@pmtk pmtk mentioned this pull request Jul 26, 2023
Closed
@pmtk
Copy link
Member Author

pmtk commented Jul 26, 2023

/retest

@dhellmann
Copy link
Contributor

dhellmann commented Jul 26, 2023

I think the issues with the metal tests here will be fixed by #2123

@pmtk pmtk mentioned this pull request Jul 26, 2023
Merged
@dhellmann
Copy link
Contributor

dhellmann commented Jul 26, 2023

/retest

@dhellmann
Copy link
Contributor

dhellmann commented Jul 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2023

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm 7728564 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 560fed8 into openshift:main Jul 27, 2023
@pmtk pmtk deleted the rebase-4.14.0-0.nightly-2023-07-26-001154_amd64-2023-07-26_arm64-2023-07-25 branch November 6, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@pacevedom pacevedom Awaiting requested review from pacevedom

Assignees

@dhellmann dhellmann

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmtk @dhellmann @openshift-merge-robot