Skip to content

Conversation

@a7vicky
Copy link
Member

@a7vicky a7vicky commented May 12, 2025

What type of PR is this?

(refactor)

What does this PR do / why do we need it?

MUO direct dependencies bump to the respective version

  • k8s.io/api v0.31.1
  • k8s.io/apimachinery v0.31.1
  • sigs.k8s.io/controller-runtime v0.19.0

Which Jira/Github issue(s) this PR fixes?

Fixes # OSD-30016

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot requested review from chamalabey and vaidehi411 May 12, 2025 08:52
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.22%. Comparing base (14278e8) to head (5ac3b92).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files         123      123           
  Lines        6124     6124           
=======================================
  Hits         3321     3321           
  Misses       2599     2599           
  Partials      204      204           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a7vicky a7vicky marked this pull request as draft May 12, 2025 17:32
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2025
@a7vicky a7vicky changed the title Dependencies bump [OSD-30016] Dependencies bump May 16, 2025
@a7vicky a7vicky marked this pull request as ready for review May 16, 2025 09:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2025
@openshift-ci openshift-ci bot requested review from charlesgong and rbhilare May 16, 2025 09:44
@ravitri
Copy link
Member

ravitri commented May 16, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2025

@a7vicky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member Author

@a7vicky a7vicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful upgrade test:

  1. 4.17.18 -> 4.17.20
  2. 4.17.20 -> 4.18.13

@devppratik
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7vicky, devppratik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a7vicky
Copy link
Member Author

a7vicky commented May 21, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 9a44c64 into openshift:master May 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants