Stop parsing our own version as semver #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now have a single image, we don't need to worry about drift between them. Previously we were trying to parse the output of `git describe` (trimmed) as a semantic version, which blew up when ART pushed a git tag that didn't conform to the previous pattern. Just refer to the literal raw tag name instead of trying to parse it. Closes: openshift#976
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
Contributor
|
@cgwalters updated the unit tests for the new version. they should pass now. |
Contributor
|
This is great and passes e2e. /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now have a single image, we don't need to worry about
drift between them.
Previously we were trying to parse the output
of
git describe(trimmed) as a semantic version, which blewup when ART pushed a git tag that didn't conform to the previous pattern.
Just refer to the literal raw tag name instead of trying to parse it.
Closes: #976