Bug 1728216: manifests: explicitely set command in deployments and daemonsets

[vrutkovs]

- What I did
Added "command" to container spec in deployments/daemonset operator syncs.

This ensures DS and deployment would be correctly synced by operator if command was modified there.

This has been fixed in 4.2 by #850, but still affects 4.1

- How to verify it
oc edit ds machine-config-server, change "args" and "command" - operator should rollback these changes

- Description for the changelog
Operator ensures "command" spec is synced in MCC / MCD

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1728216
Fixes #93

[openshift-ci-robot]

@vrutkovs: This pull request references an invalid Bugzilla bug:

• expected the bug to target the "4.1.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1728216: manifests: explicitely set command in deployments and daemonsets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vrutkovs]

/bugzilla refresh

[openshift-ci-robot]

@vrutkovs: This pull request references an invalid Bugzilla bug:

• expected the bug to target the "4.1.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vrutkovs]

/bugzilla refresh

[openshift-ci-robot]

@vrutkovs: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[runcom]

/approve

entrypoint in dockerfiles is useless now though but not a big deal anyway

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrutkovs]

Cluster operator monitoring is still updating
/retest

[crawford]

There is ongoing discussion in the BZ as to whether or not this should be backported.

/hold

Feel free to cancel the hold, future patch manager, once the discussion has been resolved.

[eparis]

Let's just go ahead and close.