Skip to content

Conversation

@mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Jul 8, 2019

- What I did
Updated GitHub.com/containers/image to v2.0.0, and ran dep update -ensure, to update everything else.

At least some of the updates are necessary for #805 , where I’ve been asked to split them into a separate PR.

(Note that #805 needs, apart from the c/image update, new subpackages for openshift/api#354 and openshift/client-go#109 , which does not show up in this PR because this PR does not add any users of those subpackages.)

- How to verify it

Existing CI, I hope

- Description for the changelog
N/A

mtrmac added 2 commits July 8, 2019 16:19
Signed-off-by: Miloslav Trmač <[email protected]>

Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 8, 2019
@mtrmac mtrmac mentioned this pull request Jul 8, 2019
@mtrmac
Copy link
Contributor Author

mtrmac commented Jul 8, 2019

/retest

@cgwalters
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1c9999b into openshift:master Jul 8, 2019
@mtrmac mtrmac deleted the update-deps branch July 8, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants