Skip to content

[4.3] WIP: Add OpenAPIv3 Validation to CRDs #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LorbusChris wants to merge 1 commit into from
Closed

[4.3] WIP: Add OpenAPIv3 Validation to CRDs #934

LorbusChris wants to merge 1 commit into from

Conversation

@LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Jul 5, 2019 •
edited
Loading

very rough WIP - really just the output from running https://github.com/openshift/crd-schema-gen on our manifests

Depends on #996 getting in first, so generation of CRDs isnt blocked by inclusion of Ign types that are missing json tags rewquired for generator.

- What I did

- How to verify it

- Description for the changelog

@LorbusChris LorbusChris requested review from runcom and vrutkovs July 5, 2019 19:57
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 5, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2019
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jul 5, 2019

/ok-to-test cancel

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jul 5, 2019

/woof

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 5, 2019

@LorbusChris: dog image

Details

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2019
@LorbusChris LorbusChris added the 4.3 label Aug 2, 2019
@LorbusChris LorbusChris changed the title WIP: Add OpenAPIv3 Validation to CRDs [4.3] WIP: Add OpenAPIv3 Validation to CRDs Aug 2, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2019
@LorbusChris LorbusChris changed the base branch from master to master-4.3 August 2, 2019 14:44
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2019
@LorbusChris LorbusChris changed the base branch from master-4.3 to master August 8, 2019 22:08
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 11, 2019

@LorbusChris: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 30, 2019

@LorbusChris: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-op e3b023c link /test e2e-aws-op
ci/prow/images e3b023c link /test images
ci/prow/e2e-aws e3b023c link /test e2e-aws
ci/prow/verify e3b023c link /test verify
ci/prow/unit e3b023c link /test unit
ci/prow/e2e-aws-disruptive e3b023c link /test e2e-aws-disruptive
ci/prow/e2e-gcp-op e3b023c link /test e2e-gcp-op
ci/prow/e2e-aws-upgrade e3b023c link /test e2e-aws-upgrade
ci/prow/e2e-gcp-upgrade e3b023c link /test e2e-gcp-upgrade
ci/prow/e2e-vsphere e3b023c link /test e2e-vsphere
ci/prow/build-rpms-from-tar e3b023c link /test build-rpms-from-tar

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice kikisdeliveryservice added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2019
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Dec 3, 2019

In an effort to clean up the MCO repo, closing old open PRs with no recent activity.

Feel free to reopen.

@LorbusChris LorbusChris deleted the openapi branch February 24, 2020 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

@runcom runcom Awaiting requested review from runcom

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LorbusChris @openshift-ci-robot @kikisdeliveryservice