Skip to content

Conversation

@kikisdeliveryservice
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice commented Jun 26, 2019

As an intermediate PR, as part of folding mco images into one image,
remove the required flag for mcc/mcd/mcs/setupetcdenv images in bootstrap.go

Required-by: openshift/installer#1875
Required-by: #895
Related-to: #739

As an intermediate PR, as part of folding mco images into one image,
remove the required flag for mcc/mcd/mcs/setupetcdenv images in bootstrap.go

Required-by: openshift/installer#1875
Required-by: openshift#895
Related-to: openshift#739
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2019
@runcom
Copy link
Member

runcom commented Jun 26, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bd4a739 into openshift:master Jun 26, 2019
@kikisdeliveryservice kikisdeliveryservice deleted the remove-reqd-image-flags branch June 26, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants