Import pivot code #859
Import pivot code #859
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
This is amazing. |
|
|
This introduces into the MCO the same CI issue that kubelet But once we fix that there will be huge benefits because this repository will become an easy place to add functionality to RHCOS that's on Github and CI gated in a useful way. |
cgwalters
force-pushed
the
mcd-pivot-merge
branch
from
0447729 to
dd179f1
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Lifting WIP on this, it doesn't actually do anything right now by default, but should be a useful baseline for further iteration. (For example there's various cleanups/dedup that we can do to the imported pivot code, but I want to do that once we have CI testing set up, etc.) |
|
Some really trivial nits which we can postpone but I'd love to get the pkg/daemon/pivot for this. Otherwise, it looks great. /approve |
This is prep for having "early MCD" process kernel arguments from MachineConfig objects at pivot time, and more generally building up the model that the host processes `MachineConfig`, not just Ignition. Right now what I've tested is just manually running `machine-config-daemon pivot registry.svc.ci.openshift.org/rhcos/machine-os-content:latest` A next step here is to have the MCS serve the extra MachineConfig data like `KernelArguments` and then have the MCD process that on boot. After that we should have this take over the early pivot role, then we can drop `/usr/bin/pivot` out of RHCOS. See: openshift#798
cgwalters
force-pushed
the
mcd-pivot-merge
branch
from
dd179f1 to
37d962f
Compare
|
/lgtm |
ashcrow
left a comment
ashcrow
left a comment
There was a problem hiding this comment.
I should select the approve radio button when I approve .... :-)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| inspectArgs = append(inspectArgs, fmt.Sprintf("%s", container)) | ||
| output := utils.RunExt(true, 1, "podman", inspectArgs...) | ||
| var imagedataArray []types.ImageInspection | ||
| json.Unmarshal([]byte(output), &imagedataArray) |
There was a problem hiding this comment.
Should there be a json err check here?
There was a problem hiding this comment.
oops i commented too late 😂
There was a problem hiding this comment.
This probably got imported as is from openshift/pivot and yeah, we should have an error check here - let's follow up all the things here :)
6 participants
This is prep for having "early MCD" process kernel arguments
from MachineConfig objects at pivot time, and more generally
building up the model that the host processes
MachineConfig,not just Ignition.
Right now what I've tested is just manually running
machine-config-daemon pivot registry.svc.ci.openshift.org/rhcos/machine-os-content:latestBut, next step is to test having this take over the early pivot role,
then we can drop
/usr/bin/pivotout of RHCOS.See: #798