Standardize import paths and run gofmt #831
Conversation
openshift-ci-robot
added
the
size/L
eparis
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
pkg/operator/assets/bindata.go
Outdated
There was a problem hiding this comment.
This file is generated, I think you need to skip it or the next person running hack/update-generated-bindata.sh will revert.
There was a problem hiding this comment.
(or, we update that script to run gofmt)
There was a problem hiding this comment.
I'm just not going to touch it.
pkg/operator/assets/bindata.go
Outdated
There was a problem hiding this comment.
(or, we update that script to run gofmt)
|
/approve |
openshift-ci-robot
added
the
approved
eparis
force-pushed
the
include-once
branch
5 times, most recently
from
1181a18 to
998fc06
Compare
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
The gofmt should be a separate commit from the manual changes to import paths that you are making.
eparis
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Some files imported the same thing twice with 2 different names. Many files called the same import something different. This just creates a bit of continuity using the most common upstream practice: corev1 "k8s.io/api/core/v1" corev1client "k8s.io/client-go/kubernetes/typed/core/v1" corev1lister "k8s.io/client-go/listers/core/v1" appsv1client "k8s.io/client-go/kubernetes/typed/apps/v1"
There probably should be a verify test to not let it get bad again.
|
@eparis: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I split it into 2 commits. If e2e-etcd-quorum-loss known bad? If so, I think it's ready to go... |
|
thanks @eparis ! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, eparis, kikisdeliveryservice, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
Some files imported the same thing twice with 2 different names. Many files
called the same import something different. This just creates a bit of
continuity using the most common upstream practice:
corev1 "k8s.io/api/core/v1"
corev1client "k8s.io/client-go/kubernetes/typed/core/v1"
corev1lister "k8s.io/client-go/listers/core/v1"
appsv1client "k8s.io/client-go/kubernetes/typed/apps/v1"
I also run the 1.12 formatter across the repo.