-
Notifications
You must be signed in to change notification settings - Fork 462
Add a machine-config-daemon.spec #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
xref #798 |
|
spec looks proper to me. One question is how this would be built and provided where RHCOS could consume the result. |
The easy answer today is that we build it the same way we build pivot right? (And then a logical step after that is to fold pivot into this repo) |
|
I started the paperwork to do the RPM builds. |
As we move towards having more things in MachineConfig, we also in many cases need the functionality during "early pivot" before the cluster is up. Let's just ship the MCD as part of the host as well so we can use the same code then. Now of course we have the same code in two places. I think what we'd want to do after this is have the "pod-MCD" call out to the "host-MCD" as a subprocess. That would actually simplify other things as well.
|
OK I rebased and did some further tweaks to the spec, which required the What I'd like to do is try to do some of this work incrementally; if we land the spec file I can get the ¹ See what I did there? |
|
/retest |
|
let's get this in to allow more testing then /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
oh this did go in just fine :/ |
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@runcom @cgwalters wait why is ci running on something that merged?? |
|
I think the parts of Prow here are asynchronous, and for non-required contexts it doesn't kill them after the PR has merged. (For required contexts, the PR needs them to merge) |
but...4 hours async? zoinks |
As we move towards having more things in MachineConfig, we also
in many cases need the functionality during "early pivot" before
the cluster is up.
Let's just ship the MCD as part of the host as well so we can use
the same code then.
Now of course we have the same code in two places. I think
what we'd want to do after this is have the "pod-MCD" call out
to the "host-MCD" as a subprocess. That would actually simplify
other things as well.