Skip to content

Conversation

@cgwalters
Copy link
Member

As we move towards having more things in MachineConfig, we also
in many cases need the functionality during "early pivot" before
the cluster is up.

Let's just ship the MCD as part of the host as well so we can use
the same code then.

Now of course we have the same code in two places. I think
what we'd want to do after this is have the "pod-MCD" call out
to the "host-MCD" as a subprocess. That would actually simplify
other things as well.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 29, 2019
@cgwalters
Copy link
Member Author

xref #798

@ashcrow
Copy link
Member

ashcrow commented May 29, 2019

spec looks proper to me. One question is how this would be built and provided where RHCOS could consume the result.

@cgwalters
Copy link
Member Author

One question is how this would be built and provided where RHCOS could consume the result.

The easy answer today is that we build it the same way we build pivot right? (And then a logical step after that is to fold pivot into this repo)

@cgwalters
Copy link
Member Author

I started the paperwork to do the RPM builds.

As we move towards having more things in MachineConfig, we also
in many cases need the functionality during "early pivot" before
the cluster is up.

Let's just ship the MCD as part of the host as well so we can use
the same code then.

Now of course we have the same code in two places.  I think
what we'd want to do after this is have the "pod-MCD" call out
to the "host-MCD" as a subprocess.  That would actually simplify
other things as well.
@cgwalters
Copy link
Member Author

OK I rebased and did some further tweaks to the spec, which required the VERSION_OVERRIDE and SOURCE_GIT_COMMIT sourcery¹ too.

What I'd like to do is try to do some of this work incrementally; if we land the spec file I can get the machine-config-daemon binary into rhcos, but it won't do anything until we start more work. If the binary is there though it'll just make it easier to hack on without having to custom deploy both RHCOS and the MCD.

¹ See what I did there?

@runcom
Copy link
Member

runcom commented Jun 4, 2019

/retest
/approve

@runcom
Copy link
Member

runcom commented Jun 4, 2019

let's get this in to allow more testing then

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3ec6550 into openshift:master Jun 4, 2019
@runcom
Copy link
Member

runcom commented Jun 4, 2019

oh this did go in just fine :/

@openshift-ci-robot
Copy link
Contributor

@cgwalters: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-etcd-quorum-loss fc66aa9 link /test e2e-etcd-quorum-loss

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor

@runcom @cgwalters wait why is ci running on something that merged??

@cgwalters
Copy link
Member Author

I think the parts of Prow here are asynchronous, and for non-required contexts it doesn't kill them after the PR has merged. (For required contexts, the PR needs them to merge)

@kikisdeliveryservice
Copy link
Contributor

I think the parts of Prow here are asynchronous, and for non-required contexts it doesn't kill them after the PR has merged. (For required contexts, the PR needs them to merge)

but...4 hours async? zoinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants