DR: add validate_environment to openshift-recovery tools #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
Contributor
Author
|
/hold holding for manual validation and @vrutkovs review |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
/test e2e-aws |
Member
|
/approve |
openshift-ci-robot
added
the
approved
vrutkovs
reviewed
May 24, 2019
templates/master/00-master/_base/files/usr-local-bin-etcd-snapshot-restore-sh.yaml
Outdated
Show resolved
Hide resolved
Contributor
|
/hold cancel Verified that it works correctly (with a fix for #793 (comment) applied) |
openshift-ci-robot
removed
the
do-not-merge/hold
vrutkovs
suggested changes
May 24, 2019
Contributor
vrutkovs
left a comment
vrutkovs
left a comment
There was a problem hiding this comment.
Typo in a function name
Signed-off-by: Sam Batschelet <[email protected]>
6 tasks
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, hexfusion, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/run/etcd/environment contains important ENV variables required by most of the DR scripts. This file is populated by the discovery container in the etcd-member init. In some circumstances such as the node rebooting this file can be missing.
validate_environmentnow checks for the existence of the file and if it is missing we populate.The second part of this PR makes $SNAPSHOT_FILE a required parameter. Currently, we default to the local members DB file backup. This I feel is not a good default and could result in unexpected results.
/cc @vrutkovs