Skip to content

Conversation

@vrutkovs
Copy link
Contributor

- What I did
Updated etcd restore script to reload systemd before starting kubelet

- How to verify it

  1. Change kubelet on disk
  2. Run etcd restore script

If the service has changed kubelet won't start without daemon reload:

+ echo 'Starting kubelet..'
+ systemctl start kubelet.service
Warning: The unit file, source configuration file or drop-ins of kubelet.service changed on disk. Run 'systemctl daemon-reload' to reload units

I'm not quite sure what's changing kubelet on disk during this procedure though

/cc @patrickdillon @hexfusion

If the service has changed kubelet won't start without daemon reload
@cgwalters
Copy link
Member

Can you add DR: or so as a "topic prefix" in the commit messages? I thought this PR was about the main kubelet config at first.

Also...hopefully at some point soon these scripts will gain a new canonical upstream in a container and we can only do backports where necessary here? 4.2 development is open, we can make new containers now...

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2019
@vrutkovs vrutkovs changed the title Reload systemd services on disk before starting kubelet DR: reload systemd services on disk before starting kubelet in etcd restore script May 22, 2019
@vrutkovs
Copy link
Contributor Author

/retest

@cgwalters
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2019
@runcom
Copy link
Member

runcom commented May 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, runcom, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants