Bug 1711879 : templates/master/00-master: resolve empty var when ETCD_CONNSTRING is not passed

[hexfusion]

This PR resolves an issue where we sourced /run/etcd/environment after we were populating $ETCD_CONNSTRING which if not passed as a param would result in ${ETCD_DNS_NAME} having no value. Also removed download_cert_recover_template function which is no longer used.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1711879

NOTE: This will fall in 4.1.z and is not blocking for 4.1

[hexfusion]

/cc @vrutkovs @runcom

[vrutkovs]

lgtm

[kikisdeliveryservice]

/approve

[kikisdeliveryservice]

will leave to @runcom & @vrutkovs to LGTM

[vrutkovs]

Verified that it fixes etcd-snapshot-restore.sh run without params.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, kikisdeliveryservice, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[vrutkovs]

May 20 13:27:33.032 W ns/openshift-support pod/support-operator-6648c5fc4-tr5wm Unable to mount volumes for pod "support-operator-6648c5fc4-tr5wm_openshift-support(bcd5e402-7b02-11e9-861e-12bd82cda442)": timeout expired waiting for volumes to attach or mount for pod "openshift-support"/"support-operator-6648c5fc4-tr5wm". list of unmounted volumes=[snapshots operator-token-42ctz]. list of unattached volumes=[snapshots operator-token-42ctz]

Not related to this PR

[hexfusion]

May 20 15:30:30.361 W ns/openshift-support pod/support-operator-5948567cb9-rmww4 Unable to mount volumes for pod "support-operator-5948567cb9-rmww4_openshift-support(ea10aa21-7b13-11e9-8f0a-0adfb7b9ac5a)": timeout expired waiting for volumes to attach or mount for pod "openshift-support"/"support-operator-5948567cb9-rmww4". list of unmounted volumes=[snapshots operator-token-2dncq]. list of unattached volumes=[snapshots operator-token-2dncq]
May 20 15:30:32.198 I test="[Disruptive] Cluster upgrade should maintain a functioning cluster [Feature:ClusterUpgrade] [Suite:openshift] [Serial]" failed

Failing tests:

[Disruptive] Cluster upgrade should maintain a functioning cluster [Feature:ClusterUpgrade] [Suite:openshift] [Serial]

error: 1 fail, 0 pass, 0 skip (1h20m31s)

/test e2e-aws-upgrade

[hexfusion]

Clayton has acked support operator bug and will disable [1],[2].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1712034
[2] openshift/support-operator#7

[hexfusion]

/test e2e-aws-upgrade

[hexfusion]

/test e2e-aws-upgrade

Support operator has now been disabled

[hexfusion]

Still not disabled I guess...

/test e2e-aws-upgrade