DR start_static_pods: reread a list of static pods when starting them #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
hexfusion
reviewed
May 20, 2019
templates/master/00-master/_base/files/usr-local-bin-openshift-recovery-tools-sh.yaml
Outdated
Show resolved
Hide resolved
6 tasks
Contributor
Author
|
/retest
|
Contributor
|
/lgtm |
Member
|
/approve |
openshift-ci-robot
added
the
approved
Contributor
Author
|
/test e2e-aws-upgrade |
added 2 commits
May 20, 2019 23:11
Script won't start all stopped pods if it was terminated and restarted. Instead it should re-read a list of pods in MANIFEST_STOPPED_DIR and move them to MANIFEST_DIR
vrutkovs
force-pushed
the
dr-start-all-pods
branch
from
8c4e589 to
8554f3a
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, hexfusion, kikisdeliveryservice, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Updated DR scripts to start all stopped pods.
Script won't start all stopped pods if it was terminated and restarted.
This may happen when pod-based ssh bastion is used and connection may break
when other masters are starting.
Instead
start_static_podsfunction should re-read a list of pods in MANIFEST_STOPPED_DIR.- How to verify it
/etc/kubernetes/manifests-stoppedwere started- Description for the changelog