JIRA PROD-1027: templates/master/00-master: optionally pass etcd connection string #776
Conversation
openshift-ci-robot
added
the
size/S
|
/hold Requires manual verification |
openshift-ci-robot
added
the
do-not-merge/hold
templates/master/00-master/_base/files/usr-local-bin-etcd-snapshot-restore-sh.yaml
Outdated
Show resolved
Hide resolved
…ection string This enables etcd restore script restore the multimember cluster
vrutkovs
force-pushed
the
dr-etcd-restore-connstring
branch
from
2801123 to
a1bbc59
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, runcom, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
| --initial-cluster ${ETCD_CONNSTRING} \ | ||
| --initial-cluster-token etcd-cluster-1 \ | ||
| --skip-hash-check=true \ | ||
| --initial-advertise-peer-urls https://${ETCD_IPV4_ADDRESS}:2380 \ |
There was a problem hiding this comment.
Since we are here we should really make this a param as well for flexability?
if [ -z "${ETCD_INIT_PEERS_URLS}" ]; then
ETCD_INITIAL_PEERS="https://${ETCD_IPV4_ADDRESS}:2380
fi
There was a problem hiding this comment.
Good catch, I'll address that in the next PR and make sure CI uses this param
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
cherry-picked in #771 |
5 participants
…
This enables etcd restore script restore the multimember cluster. This is required for CI where a 3 member cluster needs to be restored.
/cc @hexfusion @runcom