Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented May 15, 2019

Cherry-pick of commits from #734 - that PR has been missed from the branching somehow but we need that to verify the linked BZ.

@imcleod ptal

runcom added 4 commits May 15, 2019 10:40
Signed-off-by: Antonio Murdaca <runcom@linux.com>
Signed-off-by: Antonio Murdaca <runcom@linux.com>
Signed-off-by: Antonio Murdaca <runcom@linux.com>
Signed-off-by: Antonio Murdaca <runcom@linux.com>
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@runcom
Copy link
Member Author

runcom commented May 15, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 15, 2019

@runcom: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-rhel-scaleup 559ed93 link /test e2e-rhel-scaleup

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom
Copy link
Member Author

runcom commented May 15, 2019

scaleup can be overridden pls

@imcleod
Copy link
Contributor

imcleod commented May 15, 2019

/override ci/prow/e2e-rhel-scaleup

@openshift-ci-robot
Copy link
Contributor

@imcleod: Overrode contexts on behalf of imcleod: ci/prow/e2e-rhel-scaleup

Details

In response to this:

/override ci/prow/e2e-rhel-scaleup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Member Author

runcom commented May 15, 2019

needs lgtm as well to go in

@imcleod
Copy link
Contributor

imcleod commented May 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imcleod, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fe96f07 into openshift:release-4.1 May 15, 2019
@runcom runcom deleted the backport-bz1708602 branch May 15, 2019 11:55
@smarterclayton
Copy link
Contributor

This needed to be approved by a release architect. Please make sure you get that approval before merging.

@smarterclayton
Copy link
Contributor

(this is approved, just reminding folks to double ask on every PR so we can get used to the process)

@runcom
Copy link
Member Author

runcom commented May 15, 2019

My bad, sorry about this.

@smarterclayton
Copy link
Contributor

No worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants