controller: Just sanity check templates, don't copy all of them #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
needs-rebase
We haven't changed how the renderer works in forever, but a lot of people keep changing the templates. This causes pointless churn in the test data and makes changing the templates unnecessarily painful. Further, I want to change how the rendering works to inherit from a common base, and having the unit test code also parsing the templates is problematic. Let's just sanity check that we have the pull secret and kubelet unit.
cgwalters
force-pushed
the
template-test-sanity
branch
from
222bdda to
c3245b7
Compare
openshift-ci-robot
removed
the
needs-rebase
Member
|
love this |
Contributor
|
/test e2e-aws |
Contributor
|
This makes a lot of sense to me! |
runcom
reviewed
May 14, 2019
| foundPullSecretMaster := false | ||
| foundPullSecretWorker := false | ||
| foundKubeletUnitMaster := false | ||
| foundKubeletUnitWorker := false |
Member
There was a problem hiding this comment.
this is the most stupid nits every but declaring a boolean in Golang is the same as setting it to false so var found......, found .... , ..... bool is the same here (and this nit can live here for the time being, just wanted to point it out :D
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't changed how the renderer works in forever, but a lot
of people keep changing the templates. This causes pointless churn
in the test data and makes changing the templates unnecessarily
painful.
Further, I want to change how the rendering works to inherit
from a common base, and having the unit test code also parsing
the templates is problematic.
Let's just sanity check that we have the pull secret and kubelet
unit.