Skip to content

[release-4.22] OCPBUGS-105447: fix nil pointer panic in IRI controller informer race - #6390

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-6385-to-release-4.22
Aug 10, 2026
Merged

[release-4.22] OCPBUGS-105447: fix nil pointer panic in IRI controller informer race#6390
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-6385-to-release-4.22

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 9, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #6385

/assign bfournie

@redhat-chai-bot @claude @openshift-cherrypick-robot
Bug 105432: fix nil pointer panic in IRI controller informer race
4341406 
The InternalReleaseImage controller's New() constructor registered informer
event handlers before assigning the listers. When an informer is already
started, AddEventHandler replays synthetic Add events on a separate goroutine,
which could invoke isControlPlaneNode/isNodeReady before ctrl.nodeLister was
assigned, causing a nil pointer panic.

Move all lister and HasSynced assignments ahead of the AddEventHandler
registrations (pure reordering, no logic change), and add defensive nil guards
in isControlPlaneNode and isNodeReady that log a warning and return false when
the nodeLister is not yet initialized. The guard warnings intentionally omit the
node name to avoid logging potentially sensitive infrastructure identifiers.

Add TestNewWithAlreadyStartedInformers, a regression test that starts and
preloads the informers before calling New() to exercise the replayed-event path
and assert construction completes without panicking.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@openshift-merge-bot

openshift-merge-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 9, 2026
Merged
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0a4a54db-8fe1-4c1b-8613-31e60304692f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from andfasano and zaneb August 9, 2026 13:04
@openshift-ci-robot

openshift-ci-robot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-105432 has been cloned as Jira Issue OCPBUGS-105447. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-105447: fix nil pointer panic in IRI controller informer race

Details

In response to this:

This is an automated cherry-pick of #6385

/assign bfournie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-105432: fix nil pointer panic in IRI controller informer race [release-4.22] OCPBUGS-105447: fix nil pointer panic in IRI controller informer race Aug 9, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-105447, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-105432 to target a version in 5.0.0, but it targets "5.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #6385

/assign bfournie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 9, 2026
@bfournie

bfournie commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-105447, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-105432 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-105432 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 9, 2026
@zaneb

zaneb commented Aug 10, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-merge-bot

openshift-merge-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@zaneb

zaneb commented Aug 10, 2026

Copy link
Copy Markdown
Member

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 10, 2026
@bfournie

bfournie commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

/test ?

@bfournie

bfournie commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

/test e2e-agent-compact-ipv4-iso-no-registry

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie

bfournie commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

/verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@bfournie: This PR has been marked as verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry.

Details

In response to this:

/verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 3ca7121 into openshift:release-4.22 Aug 10, 2026
19 checks passed
@openshift-ci-robot

openshift-ci-robot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-105447
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-105447 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #6385

/assign bfournie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

openshift-merge-robot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Fix included in release 4.22.0-0.nightly-2026-08-10-215205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano
@zaneb zaneb Awaiting requested review from zaneb

Assignees

@zaneb zaneb

@rbbratta rbbratta

@bfournie bfournie

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@imatza-rh imatza-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.