Skip to content

Conversation

@sjenning
Copy link
Contributor

@sjenning sjenning commented Sep 14, 2018

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 14, 2018
@mrunalp
Copy link
Member

mrunalp commented Sep 14, 2018

Looks fine to me 👍

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Sep 14, 2018

can you add separate commit for test generated data
go test ./pkg/controller/template/... -u from root of the repo

@sjenning
Copy link
Contributor Author

@rphillips this overlaps with #52. We can close that and open a new PR for updating the repo list. The PR conflated the two changes kinda.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2018
@rphillips
Copy link
Contributor

lgtm

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2018
@openshift-merge-robot openshift-merge-robot merged commit bc5a2aa into openshift:master Sep 14, 2018
osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
add verbose logging config option to operator binary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants