Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented Apr 10, 2019

Signed-off-by: Antonio Murdaca [email protected]

- What I did

Switched go version in images from 1.10 to 1.11 (openshift/release#3394)
This allows us to finally have #600 to be consistent with gofmt and can go in

- How to verify it

CI

- Description for the changelog

Signed-off-by: Antonio Murdaca <[email protected]>
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 10, 2019
@runcom
Copy link
Member Author

runcom commented Apr 10, 2019

The openshift/release PR is here openshift/release#3413

@runcom runcom mentioned this pull request Apr 10, 2019
@LorbusChris
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2019
@runcom
Copy link
Member Author

runcom commented Apr 10, 2019

/retest

@runcom
Copy link
Member Author

runcom commented Apr 10, 2019

/hold
/lgtm cancel

(this is at risk for 4.1 and openshift/release PR to be reverted but let's hold for now)

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 10, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom
Copy link
Member Author

runcom commented Apr 10, 2019

This is gonna be 4.2

@runcom runcom added the 4.2 label Apr 10, 2019
@openshift-ci-robot
Copy link
Contributor

@runcom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 11443ce link /test e2e-aws-upgrade
ci/prow/e2e-aws-op 11443ce link /test e2e-aws-op
ci/prow/e2e-aws 11443ce link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom runcom closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants