pkg/operator: wait for cache on mcp/cc/mcp

[runcom]

Signed-off-by: Antonio Murdaca [email protected]

- What I did

added cache sync for the other listers we are using in the operator

- How to verify it

CI

- Description for the changelog

[kikisdeliveryservice]

MCO has error:
E0408 11:13:16.236440 1 reflector.go:134] github.com/openshift/machine-config-operator/pkg/generated/informers/externalversions/factory.go:101: Failed to list *v1.ControllerConfig: the server could not find the requested resource (get controllerconfigs.machineconfiguration.openshift.io)

is that this pr? or?

[runcom]

I believe that's normal since the config operator fails:

items: [
{
apiVersion: "config.openshift.io/v1",
kind: "ClusterOperator",
metadata: {
creationTimestamp: "2019-04-08T10:51:13Z",
generation: 1,
name: "authentication",
resourceVersion: "12577",
selfLink: "/apis/config.openshift.io/v1/clusteroperators/authentication",
uid: "3a112048-59ec-11e9-989d-0a0aad7aab7e"
},
spec: { },
status: {
conditions: [
{
lastTransitionTime: "2019-04-08T10:51:13Z",
message: "Failing: error checking payload readiness: unable to check route health: failed to GET route: EOF",
reason: "Failing",
status: "True",
type: "Failing"
},

nothing is progressing afaict

[kikisdeliveryservice]

I think the 3 informer commits should be squashed here just to tighten up the commits a bit.

[runcom]

I think the 3 informer commits should be squashed here just to tighten up the commits a bit.

They are 3 different units

• fix a bug
• refractor a loop
• refactor client usages

If I'll look at a single commit mixing those together in the future I would feel bad lol

[runcom]

BTW, I've removed the last commit since it's not in #610 🎉

[LorbusChris]

lgtm pending CI success!

[LorbusChris]

aws: bootstrap complete timed out

/retest

[runcom]

I'm starting to think something is broken in this PR as tests aren't passing at all. Will check again later today but I'm pretty sure other PRs are passing tests just fine.

[kikisdeliveryservice]

seeing in e2e-aws/artifacts/e2e-aws/bootstrap/openshift.service:
Apr 09 13:36:25 ip-10-0-10-57 openshift.sh[1346]: error: unable to recognize "./99_openshift-machineconfig_master.yaml": no matches for kind "MachineConfig" in version "machineconfiguration.openshift.io/v1

[runcom]

ok I've finally understood what's happening here! (basically MC,MCP,CC aren't even a thing by the time we try to sync informers cause we haven't installed the CRDs...). I'll rework this out a bit.

[runcom]

Should be fixed now

[runcom]

/retest

[runcom]

oh finally this turned green and the others are going to as well

[kikisdeliveryservice]

/lgtm

[cgwalters]

Nice work on this, love the split-up commits!

[runcom]

/lgtm

wut, it ignored @kikisdeliveryservice lgtm 🤔

[kikisdeliveryservice]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kikisdeliveryservice]

@runcom that's really weird!!!

[runcom]

/retest