AGENT-1514: Add ML-KEM verification test for IRI registry

[rwsu]

- What I did

Added a new e2e test TestIRIController_VerifyMLKEMSupport that verifies the IRI registry supports ML-KEM post-quantum key exchange (X25519MLKEM768) as required for OpenShift 4.22+. The test connects to the registry via api-int using the IRI CA cert and openssl s_client, explicitly requesting the X25519MLKEM768 key exchange group, then asserts that TLS 1.3 was negotiated and the ML-KEM group was used.

- How to verify it

Run on cluster with NoRegistryClusterInstall feature gate:
go test ./test/e2e-iri/... -run TestIRIController_VerifyMLKEMSupport -v -timeout 5m
Expected output:
Negotiated TLS1.3 group: X25519MLKEM768
New, TLSv1.3, Cipher is TLS_AES_128_GCM_SHA256
--- PASS: TestIRIController_VerifyMLKEMSupport

- Description for the changelog

Add e2e test to verify IRI registry supports ML-KEM (X25519MLKEM768) post-quantum key exchange over TLS 1.3.

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for ML-KEM post-quantum key exchange support in the IRI registry with dedicated capability validation tests.
  • Improved test infrastructure with dynamic certificate path configuration for better environment adaptability.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@rwsu: This pull request references AGENT-1514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

- What I did

Added a new e2e test TestIRIController_VerifyMLKEMSupport that verifies the IRI registry supports ML-KEM post-quantum key exchange (X25519MLKEM768) as required for OpenShift 4.22+. The test connects to the registry via api-int using the IRI CA cert and openssl s_client, explicitly requesting the X25519MLKEM768 key exchange group, then asserts that TLS 1.3 was negotiated and the ML-KEM group was used.

- How to verify it

Run on cluster with NoRegistryClusterInstall feature gate:
go test ./test/e2e-iri/... -run TestIRIController_VerifyMLKEMSupport -v -timeout 5m
Expected output:
Negotiated TLS1.3 group: X25519MLKEM768
New, TLSv1.3, Cipher is TLS_AES_128_GCM_SHA256
--- PASS: TestIRIController_VerifyMLKEMSupport

- Description for the changelog

Add e2e test to verify IRI registry supports ML-KEM (X25519MLKEM768) post-quantum key exchange over TLS 1.3.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rwsu]

/test e2e-agent-compact-ipv4-iso-no-registry

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cd9ae776-1dce-4758-88d9-a7e3c45243ea

📥 Commits

Reviewing files that changed from the base of the PR and between 3951ac7 and e0a0806.

📒 Files selected for processing (1)

• test/e2e-iri/iri_test.go

---

Walkthrough

The pull request expands IRI registry test coverage by adding ML-KEM (post-quantum key exchange) support verification. It introduces import adjustments for dynamic certificate path construction and adds a new test function that confirms IRI registry capability for X25519MLKEM768 TLS group usage.

Changes

ML-KEM Support Testing

Layer / File(s)	Summary
Imports & Constants test/e2e-iri/iri_test.go (lines 28–34)	Constants package imported and iriRootCAPath redefined to dynamically construct the CA certificate path using /rootfs prefix combined with the imported constant.
ML-KEM Verification Test test/e2e-iri/iri_test.go (lines 436–459)	New test function TestIRIController_VerifyMLKEMSupport added to verify IRI registry supports X25519MLKEM768 TLS group, confirms TLS 1.3 capability, and validates ML-KEM group presence in OpenSSL client output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Microshift Test Compatibility	⚠️ Warning	Test uses Infrastructure (config.openshift.io) and ControllerConfig APIs unavailable on MicroShift, with no proper skip protection.	Add [apigroup:config.openshift.io] tag to test name or guard with exutil.IsMicroShiftCluster() check. The skipIfNoBaremetal() itself uses Infrastructure API and fails on MicroShift.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'AGENT-1514: Add ML-KEM verification test for IRI registry' accurately and specifically describes the main change: adding a new ML-KEM verification test for the IRI registry.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The custom check applies to Ginkgo tests only. The PR adds a standard Go test function using testing.T, not Ginkgo. No Ginkgo patterns found in the file.
Test Structure And Quality	✅ Passed	Test follows codebase patterns with single responsibility, meaningful assertions, and no resource cleanup needed. Custom check targets Ginkgo; this file uses standard Go testing.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Test is standard Go test (testing.T), not Ginkgo. Check applies only to Ginkgo tests with It(), Describe(), Context(), or When().
Topology-Aware Scheduling Compatibility	✅ Passed	This PR adds only test code with no deployment manifests, operator code, or scheduling constraints. No affinity rules, node selectors, or topology assumptions introduced.
Ote Binary Stdout Contract	✅ Passed	PR adds test function with no process-level stdout writes. No init(), TestMain(), BeforeSuite() or suite-level modifications. All logging uses t.Logf() which the test framework intercepts.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The new test does not contain IPv4 assumptions or external connectivity requirements. It uses cluster-internal DNS (api-int) and standard hostname:port construction compatible with both IPv4 and IPv6.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.1)

Command failed

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rwsu]

/test unit

[andfasano]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/e2e-iri/OWNERS [andfasano,rwsu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rwsu]

/retest-required
/verified by e2e-agent-compact-ipv4-iso-no-registry TestIRIController_VerifyMLKEMSupport iri-e2e test

[openshift-ci-robot]

@rwsu: This PR has been marked as verified by e2e-agent-compact-ipv4-iso-no-registry TestIRIController_VerifyMLKEMSupport iri-e2e test.

Details

In response to this:

/retest-required
/verified by e2e-agent-compact-ipv4-iso-no-registry TestIRIController_VerifyMLKEMSupport iri-e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD a3aedcb and 2 for PR HEAD e0a0806 in total

[openshift-ci]

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.