[WIP] * : Ignition v2 to v3 transition #583

kikisdeliveryservice · 2019-03-26T18:30:09Z

Updating MC* to use ignition v3. The following changes are included:

ssh keys now written to /home/core/.ssh/authorized_keys.d/ignition
code changes to use v3 and remove usage of v2.2.0
unit and e2e test updates
updated golden files
remove the use of container-linux-config-transpiler in render.go and
use v3 types instead
vendor bump (incl: updating ignition version and removing contaniner-linux-config-transpiler)

Requires: openshift/installer#1468

Closes #565

openshift-ci-robot · 2019-03-26T18:30:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/daemon/update.go

...late/test_data/templates/worker/01-worker-kubelet/vpshere/files/-etc-kubernetes-kubelet.conf

lib/resourceapply/machineconfig_test.go

pkg/controller/common/helpers.go

runcom · 2019-03-27T08:55:38Z

Gopkg.toml

 [[constraint]]
  name = "github.com/coreos/ignition"
-  version = "0.26.0"
+  branch = "master"


we can now use 2.0.0-alpha tag iirc

ah ok i was following your installer pr

lib/resourceapply/machineconfig_test.go

runcom · 2019-03-27T08:56:50Z

awesome 😍

kikisdeliveryservice · 2019-03-28T00:07:55Z

looks like I'm seeing similar problems in TestKubeletConfigCreate as #417
#417 (comment)

pkg/controller/container-runtime-config/container_runtime_config_controller.go

pkg/controller/kubelet-config/kubelet_config_controller.go

pkg/controller/kubelet-config/kubelet_config_features.go

pkg/controller/template/render.go

pkg/controller/template/render_test.go

eparis · 2019-03-29T02:33:10Z

/hold
as this PR (in conjunction with the others) would, as I understand it, break upgrades it may not merge during the customer promised beta3 upgrade window.

ajeddeloh

Does this drop the special handling with ssh keys? Merge() should be doing the right thing now.

docs/MachineConfigServer.md

pkg/apis/machineconfiguration.openshift.io/v1/helpers.go

pkg/controller/container-runtime-config/container_runtime_config_controller.go

pkg/controller/template/render.go

pkg/controller/template/test_data/templates/master/00-master/aws/files/-etc-kubernetes-ca.crt

kikisdeliveryservice · 2019-03-29T17:18:00Z

Does this drop the special handling with ssh keys? Merge() should be doing the right thing now.

special handling?

kikisdeliveryservice · 2019-03-29T17:35:03Z

Going to look into the SSH stuff after talking to @ajeddeloh

ajeddeloh · 2019-03-29T18:22:59Z

Summarizing some discussion: The SSH stuff is not needed for this and is just cleanup, so we'll keep it out of this PR to clean the number of variables small.

Updating MC* to use ignition v3. The following changes are included: - ssh keys now written to /home/core/.ssh/authorized_keys.d/ignition - code changes to use v3 and remove usage of v2.2.0 - unit and e2e test updates - updated golden files - remove the use of container-linux-config-transpiler in render.go and use v3 types instead Requires: openshift/installer#1468 Closes: openshift#565

openshift-ci-robot · 2019-04-02T19:01:29Z

@kikisdeliveryservice: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-11-30T13:30:37Z

@kikisdeliveryservice: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`afc54e8`	link	`/test e2e-aws`
ci/prow/e2e-aws-op	`afc54e8`	link	`/test e2e-aws-op`
ci/prow/e2e-aws-disruptive	`afc54e8`	link	`/test e2e-aws-disruptive`
ci/prow/e2e-gcp-op	`afc54e8`	link	`/test e2e-gcp-op`
ci/prow/e2e-aws-upgrade	`afc54e8`	link	`/test e2e-aws-upgrade`
ci/prow/e2e-gcp-upgrade	`afc54e8`	link	`/test e2e-gcp-upgrade`
ci/prow/e2e-vsphere	`afc54e8`	link	`/test e2e-vsphere`
ci/prow/build-rpms-from-tar	`afc54e8`	link	`/test build-rpms-from-tar`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kikisdeliveryservice · 2019-12-03T22:40:05Z

In an effort to clean up the MCO repo, closing old open PRs with no recent activity.

Feel free to reopen.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2019

openshift-ci-robot requested review from ashcrow and runcom March 26, 2019 18:30

rphillips reviewed Mar 26, 2019

View reviewed changes

pkg/daemon/update.go Outdated Show resolved Hide resolved

kikisdeliveryservice force-pushed the ign-update branch from 86fcf99 to dba3422 Compare March 26, 2019 19:18

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2019

kikisdeliveryservice force-pushed the ign-update branch 5 times, most recently from 6c7a19c to ec34743 Compare March 27, 2019 06:39

runcom reviewed Mar 27, 2019

View reviewed changes

...late/test_data/templates/worker/01-worker-kubelet/vpshere/files/-etc-kubernetes-kubelet.conf Outdated Show resolved Hide resolved

runcom reviewed Mar 27, 2019

View reviewed changes

lib/resourceapply/machineconfig_test.go Outdated Show resolved Hide resolved

runcom reviewed Mar 27, 2019

View reviewed changes

pkg/controller/common/helpers.go Outdated Show resolved Hide resolved

runcom reviewed Mar 27, 2019

View reviewed changes

lib/resourceapply/machineconfig_test.go Outdated Show resolved Hide resolved

kikisdeliveryservice force-pushed the ign-update branch from ec34743 to d46c55f Compare March 27, 2019 16:24

kikisdeliveryservice mentioned this pull request Mar 27, 2019

mcc: fix spelling of vsphere and update golden files #589

Merged

kikisdeliveryservice force-pushed the ign-update branch 3 times, most recently from d9e5be8 to 981c2f2 Compare March 27, 2019 23:46

kikisdeliveryservice force-pushed the ign-update branch 3 times, most recently from e47bfe5 to 9e1dc44 Compare March 28, 2019 01:41

runcom reviewed Mar 28, 2019

View reviewed changes

pkg/controller/container-runtime-config/container_runtime_config_controller.go Outdated Show resolved Hide resolved

runcom reviewed Mar 28, 2019

View reviewed changes

pkg/controller/kubelet-config/kubelet_config_controller.go Outdated Show resolved Hide resolved

runcom reviewed Mar 28, 2019

View reviewed changes

pkg/controller/kubelet-config/kubelet_config_features.go Outdated Show resolved Hide resolved

runcom reviewed Mar 28, 2019

View reviewed changes

pkg/controller/template/render.go Outdated Show resolved Hide resolved

kikisdeliveryservice force-pushed the ign-update branch from 0258977 to 2968cff Compare March 29, 2019 00:09

runcom reviewed Mar 29, 2019

View reviewed changes

pkg/controller/template/render_test.go Outdated Show resolved Hide resolved

kikisdeliveryservice force-pushed the ign-update branch 3 times, most recently from 45f6c26 to 612416c Compare March 29, 2019 02:13

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2019

kikisdeliveryservice mentioned this pull request Mar 29, 2019

mcc: replace cttypes with ign v3 types #565

Closed

kikisdeliveryservice changed the title ~~WIP update ign v2 -> v3~~ [WIP] Ignition v2 to v3 transition Mar 29, 2019

kikisdeliveryservice changed the title ~~[WIP] Ignition v2 to v3 transition~~ [WIP] * : Ignition v2 to v3 transition Mar 29, 2019

ajeddeloh reviewed Mar 29, 2019

View reviewed changes

kikisdeliveryservice force-pushed the ign-update branch from 612416c to 7406a09 Compare March 29, 2019 18:29

kikisdeliveryservice added 2 commits March 29, 2019 11:50

Ignition v2 to v3 transition : Vendor Bump

afc54e8

kikisdeliveryservice force-pushed the ign-update branch from 7406a09 to afc54e8 Compare March 29, 2019 18:50

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2019

kikisdeliveryservice mentioned this pull request Apr 9, 2019

*: pre-transition ign refactor #610

Merged

wking mentioned this pull request Apr 30, 2019

RFE: Move user-data secret creation from the installer into the MCO #683

Closed

kikisdeliveryservice added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2019

kikisdeliveryservice closed this Dec 3, 2019

[WIP] * : Ignition v2 to v3 transition #583

[WIP] * : Ignition v2 to v3 transition #583

Uh oh!

Conversation

kikisdeliveryservice commented Mar 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 26, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

runcom Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

kikisdeliveryservice Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

runcom commented Mar 27, 2019

Uh oh!

kikisdeliveryservice commented Mar 28, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eparis commented Mar 29, 2019

Uh oh!

ajeddeloh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kikisdeliveryservice commented Mar 29, 2019

Uh oh!

kikisdeliveryservice commented Mar 29, 2019

Uh oh!

ajeddeloh commented Mar 29, 2019

Uh oh!

openshift-ci-robot commented Apr 2, 2019

Uh oh!

openshift-ci-robot commented Nov 30, 2019

Uh oh!

kikisdeliveryservice commented Dec 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kikisdeliveryservice commented Mar 26, 2019 •

edited

Loading