Bug 1677198: pkg/daemon: allow empty new links section #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is further fixing https://bugzilla.redhat.com/show_bug.cgi?id=1677198 by allowing an old cluster to contain links (coming from openshift#535) which are then removed when upgrading to post openshift#540. What's happening to QE is that: 1) they're starting a cluster with an MCO version which contains openshift#535 2) they're upgrading to a payload which doesn't have openshift#535 cause it has openshift#540 which reverts openshift#535 The above means that point 1) generates MachineConfigs with an unsupported symlink and when upgrading to 2), the symlink is removed causing drift and an unreconcilable error. QE can start testing with a newer MCO version to avoid this, but for ease of testing, let's add this snippet to make sure getting rid of links, which we don't support anyway, just works. Signed-off-by: Antonio Murdaca <[email protected]>
Member
Author
|
@cgwalters ptal |
openshift-ci-robot
added
size/XS
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
|
Software...fix one thing break another, always the story... /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is further fixing https://bugzilla.redhat.com/show_bug.cgi?id=1677198 by
allowing an old cluster to contain links (coming from #535) which are
then removed when upgrading to post #540.
What's happening to QE is that:
The above means that point 1) generates MachineConfigs with an unsupported symlink and when
upgrading to 2), the symlink is removed causing drift and an unreconcilable error.
QE can start testing with a newer MCO version to avoid this, but for
ease of testing, let's add this snippet to make sure getting rid of
links, which we don't support anyway, just works.
Signed-off-by: Antonio Murdaca [email protected]