Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Sep 13, 2018

Bumping our vendored installer to pick up openshift/installer#237, and updating the test to match.

/assign @abhinavdahiya

Pulling in openshift/install@726220d0 (pkg/types/machinepools: Replace
platformConfig with platform, 2018-09-12, openshift/installer#237).

Generated with:

  $ dep ensure -update github.com/openshift/installer
Catching us up with the previous commit's vendor bump.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2018
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9bcdea7 into openshift:master Sep 13, 2018
@wking wking deleted the platformConfig-to-platform branch September 13, 2018 17:18
osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
fix samplesRegistry processing; only update DockerImage kind tag refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants