AGENT-1449: Add IRI registry authentication support to MCO - #5765
Conversation
|
@rwsu: An error was encountered searching for bug AGENT-1449 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://issues.redhat.com/rest/api/2/issue/AGENT-1449": GET https://issues.redhat.com/rest/api/2/issue/AGENT-1449 giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughTracks an Internal Release Image auth Secret through bootstrap, controller, and renderer; exposes htpasswd to templates; merges IRI registry credentials into the cluster pull secret when appropriate; updates templates and adds unit tests for auth handling and pull-secret merging. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
pkg/controller/internalreleaseimage/internalreleaseimage_controller.go (1)
378-383: Consider whether merge failure should be fatal.If the IRI auth secret exists, it indicates auth is configured for the registry. When merging credentials into the pull secret fails, nodes may be unable to pull from the authenticated registry. The current warning-only approach could lead to silent authentication failures at runtime.
Consider whether this should return an error to trigger a retry, or at least emit an event for visibility.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller.go` around lines 378 - 383, Currently mergeIRIAuthIntoPullSecret failure is only logged with klog.Warningf which can hide critical pull-auth problems; change this to return the error from the surrounding reconcile path so the controller retries (i.e., replace the klog.Warningf branch with a return fmt.Errorf(...) or wrapped err from the Reconcile method when ctrl.mergeIRIAuthIntoPullSecret(cconfig, iriAuthSecret) fails), and additionally emit a Kubernetes event for visibility using the controller's event recorder (e.g., ctrl.recorder.Eventf or ctrl.eventRecorder.Eventf) mentioning the merge failure and the secret name (iriAuthSecret) so operators see the issue in events.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkg/controller/internalreleaseimage/pullsecret.go`:
- Around line 21-31: The code currently constructs iriRegistryHost using
baseDomain without validation, which allows empty/whitespace domains (producing
"api-int.:22625"); before creating iriRegistryHost validate baseDomain (e.g.,
use strings.TrimSpace(baseDomain) and check for empty), and if invalid return an
error (e.g., fmt.Errorf("empty baseDomain") ) so the function fails fast; update
the section that defines iriRegistryHost to perform this check and only build
iriRegistryHost after validation.
In
`@pkg/controller/internalreleaseimage/templates/master/files/usr-local-bin-load-registry-image-sh.yaml`:
- Line 40: The podman pull call unconditionally uses --authfile
/var/lib/kubelet/config.json which fails if that file is missing; change the
logic around the podman pull with registryImage so you first test for the
authfile's existence (e.g. [ -f /var/lib/kubelet/config.json ] and non-empty)
and only add --authfile /var/lib/kubelet/config.json when present, otherwise
perform an unauthenticated podman pull "${registryImage}" fallback; ensure the
conditional preserves current error handling and quoting of registryImage.
---
Nitpick comments:
In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller.go`:
- Around line 378-383: Currently mergeIRIAuthIntoPullSecret failure is only
logged with klog.Warningf which can hide critical pull-auth problems; change
this to return the error from the surrounding reconcile path so the controller
retries (i.e., replace the klog.Warningf branch with a return fmt.Errorf(...) or
wrapped err from the Reconcile method when
ctrl.mergeIRIAuthIntoPullSecret(cconfig, iriAuthSecret) fails), and additionally
emit a Kubernetes event for visibility using the controller's event recorder
(e.g., ctrl.recorder.Eventf or ctrl.eventRecorder.Eventf) mentioning the merge
failure and the secret name (iriAuthSecret) so operators see the issue in
events.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 28340cd8-6caf-4ee6-8c24-9145c611edd0
📒 Files selected for processing (13)
pkg/controller/bootstrap/bootstrap.gopkg/controller/common/constants.gopkg/controller/internalreleaseimage/internalreleaseimage_bootstrap.gopkg/controller/internalreleaseimage/internalreleaseimage_bootstrap_test.gopkg/controller/internalreleaseimage/internalreleaseimage_controller.gopkg/controller/internalreleaseimage/internalreleaseimage_controller_test.gopkg/controller/internalreleaseimage/internalreleaseimage_helpers_test.gopkg/controller/internalreleaseimage/internalreleaseimage_renderer.gopkg/controller/internalreleaseimage/pullsecret.gopkg/controller/internalreleaseimage/pullsecret_test.gopkg/controller/internalreleaseimage/templates/master/files/iri-registry-auth-htpasswd.yamlpkg/controller/internalreleaseimage/templates/master/files/usr-local-bin-load-registry-image-sh.yamlpkg/controller/internalreleaseimage/templates/master/units/iri-registry.service.yaml
|
/cc @andfasano |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pkg/controller/internalreleaseimage/internalreleaseimage_controller.go (1)
348-350: Silent error suppression is intentional but consider logging.The comment explains this is for upgrade compatibility, but silently discarding errors could mask issues beyond "not found" (e.g., permission errors). Consider at least logging unexpected errors.
💡 Suggested improvement
// Auth secret may not exist during upgrades from non-auth clusters - iriAuthSecret, _ := ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName) + iriAuthSecret, err := ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName) + if err != nil && !errors.IsNotFound(err) { + klog.V(4).Infof("Could not get IRI auth secret: %v", err) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller.go` around lines 348 - 350, The code currently discards the error returned by ctrl.secretLister.Secrets(...).Get when retrieving iriAuthSecret; change it to capture the error (e.g., iriAuthSecret, err := ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName) ) and if err != nil and the error is not a NotFound (use apierrors.IsNotFound(err)) log the unexpected error with the controller logger (e.g., ctrl.Log or the controller's logger instance) including context like "getting InternalReleaseImageAuthSecret" and the err; keep the existing behavior of silently continuing on NotFound to preserve upgrade compatibility.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller.go`:
- Around line 348-350: The code currently discards the error returned by
ctrl.secretLister.Secrets(...).Get when retrieving iriAuthSecret; change it to
capture the error (e.g., iriAuthSecret, err :=
ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName)
) and if err != nil and the error is not a NotFound (use
apierrors.IsNotFound(err)) log the unexpected error with the controller logger
(e.g., ctrl.Log or the controller's logger instance) including context like
"getting InternalReleaseImageAuthSecret" and the err; keep the existing behavior
of silently continuing on NotFound to preserve upgrade compatibility.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3bcaa665-1174-478d-bf7c-2e0eae80cbf1
📒 Files selected for processing (13)
pkg/controller/bootstrap/bootstrap.gopkg/controller/common/constants.gopkg/controller/internalreleaseimage/internalreleaseimage_bootstrap.gopkg/controller/internalreleaseimage/internalreleaseimage_bootstrap_test.gopkg/controller/internalreleaseimage/internalreleaseimage_controller.gopkg/controller/internalreleaseimage/internalreleaseimage_controller_test.gopkg/controller/internalreleaseimage/internalreleaseimage_helpers_test.gopkg/controller/internalreleaseimage/internalreleaseimage_renderer.gopkg/controller/internalreleaseimage/pullsecret.gopkg/controller/internalreleaseimage/pullsecret_test.gopkg/controller/internalreleaseimage/templates/master/files/iri-registry-auth-htpasswd.yamlpkg/controller/internalreleaseimage/templates/master/files/usr-local-bin-load-registry-image-sh.yamlpkg/controller/internalreleaseimage/templates/master/units/iri-registry.service.yaml
🚧 Files skipped from review as they are similar to previous changes (6)
- pkg/controller/common/constants.go
- pkg/controller/internalreleaseimage/templates/master/files/usr-local-bin-load-registry-image-sh.yaml
- pkg/controller/internalreleaseimage/pullsecret.go
- pkg/controller/internalreleaseimage/internalreleaseimage_renderer.go
- pkg/controller/internalreleaseimage/templates/master/files/iri-registry-auth-htpasswd.yaml
- pkg/controller/internalreleaseimage/pullsecret_test.go
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-reference
|
@rwsu: This pull request references AGENT-1449 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
pkg/controller/internalreleaseimage/pullsecret_test.go (1)
53-66: Consider adding a test case for empty baseDomain.The
MergeIRIAuthIntoPullSecretfunction returns an error when baseDomain is empty (seepullsecret.golines 21-23), but this behavior isn't tested. Adding a test case would ensure this validation remains intact.Suggested test case
{ name: "missing auths field returns error", pullSecret: `{"registry":"quay.io"}`, password: "testpassword", baseDomain: "example.com", expectError: true, }, + { + name: "empty baseDomain returns error", + pullSecret: basePullSecret, + password: "testpassword", + baseDomain: "", + expectError: true, + },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/controller/internalreleaseimage/pullsecret_test.go` around lines 53 - 66, Add a unit test in pullsecret_test.go that verifies MergeIRIAuthIntoPullSecret returns an error when baseDomain is an empty string; locate the test table in the existing tests (near the cases named "invalid JSON returns error" and "missing auths field returns error") and add a new case with name like "empty baseDomain returns error", pullSecret set to a valid JSON auth object, password set to a non-empty value, baseDomain set to "", and expectError true to assert the function MergeIRIAuthIntoPullSecret enforces the non-empty baseDomain validation.pkg/controller/internalreleaseimage/internalreleaseimage_controller.go (1)
348-350: Consider distinguishing NotFound from unexpected errors when fetching auth secret.Line 349 silently discards all errors, which is intentional for upgrade compatibility (auth secret may not exist). However, this also masks unexpected errors (e.g., network issues, RBAC problems) that might warrant logging or different handling.
Suggested improvement
// Auth secret may not exist during upgrades from non-auth clusters - iriAuthSecret, _ := ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName) + iriAuthSecret, err := ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName) + if err != nil && !errors.IsNotFound(err) { + klog.V(4).Infof("Could not get IRI auth secret %s: %v", ctrlcommon.InternalReleaseImageAuthSecretName, err) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller.go` around lines 348 - 350, When fetching the auth secret with ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName) do not ignore all errors: check the returned error and use apierrors.IsNotFound(err) to treat a missing secret as OK for upgrades, but for any other error log it (via the controller logger) and return/requeue the reconcile with the error so transient RBAC/network issues are surfaced; update the code around iriAuthSecret acquisition in internalreleaseimage_controller.go to handle these two cases explicitly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller.go`:
- Around line 348-350: When fetching the auth secret with
ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName)
do not ignore all errors: check the returned error and use
apierrors.IsNotFound(err) to treat a missing secret as OK for upgrades, but for
any other error log it (via the controller logger) and return/requeue the
reconcile with the error so transient RBAC/network issues are surfaced; update
the code around iriAuthSecret acquisition in internalreleaseimage_controller.go
to handle these two cases explicitly.
In `@pkg/controller/internalreleaseimage/pullsecret_test.go`:
- Around line 53-66: Add a unit test in pullsecret_test.go that verifies
MergeIRIAuthIntoPullSecret returns an error when baseDomain is an empty string;
locate the test table in the existing tests (near the cases named "invalid JSON
returns error" and "missing auths field returns error") and add a new case with
name like "empty baseDomain returns error", pullSecret set to a valid JSON auth
object, password set to a non-empty value, baseDomain set to "", and expectError
true to assert the function MergeIRIAuthIntoPullSecret enforces the non-empty
baseDomain validation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 347c1736-456a-4dc9-a7a5-da14b0b1b0b1
📒 Files selected for processing (13)
pkg/controller/bootstrap/bootstrap.gopkg/controller/common/constants.gopkg/controller/internalreleaseimage/internalreleaseimage_bootstrap.gopkg/controller/internalreleaseimage/internalreleaseimage_bootstrap_test.gopkg/controller/internalreleaseimage/internalreleaseimage_controller.gopkg/controller/internalreleaseimage/internalreleaseimage_controller_test.gopkg/controller/internalreleaseimage/internalreleaseimage_helpers_test.gopkg/controller/internalreleaseimage/internalreleaseimage_renderer.gopkg/controller/internalreleaseimage/pullsecret.gopkg/controller/internalreleaseimage/pullsecret_test.gopkg/controller/internalreleaseimage/templates/master/files/iri-registry-auth-htpasswd.yamlpkg/controller/internalreleaseimage/templates/master/files/usr-local-bin-load-registry-image-sh.yamlpkg/controller/internalreleaseimage/templates/master/units/iri-registry.service.yaml
🚧 Files skipped from review as they are similar to previous changes (5)
- pkg/controller/common/constants.go
- pkg/controller/internalreleaseimage/pullsecret.go
- pkg/controller/internalreleaseimage/templates/master/files/iri-registry-auth-htpasswd.yaml
- pkg/controller/internalreleaseimage/templates/master/units/iri-registry.service.yaml
- pkg/controller/internalreleaseimage/internalreleaseimage_helpers_test.go
|
/retest-required |
openshift-ci
Bot
added
the
needs-rebase
openshift-ci
Bot
removed
the
needs-rebase
There was a problem hiding this comment.
🧹 Nitpick comments (2)
pkg/controller/internalreleaseimage/internalreleaseimage_controller.go (2)
348-349: Silently ignoring all errors when fetching auth secret.The error is completely discarded, which means transient failures (network issues, RBAC problems) are silently ignored and may delay auth propagation without any indication. Consider logging non-NotFound errors.
♻️ Proposed fix
// Auth secret may not exist during upgrades from non-auth clusters - iriAuthSecret, _ := ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName) + iriAuthSecret, err := ctrl.secretLister.Secrets(ctrlcommon.MCONamespace).Get(ctrlcommon.InternalReleaseImageAuthSecretName) + if err != nil && !errors.IsNotFound(err) { + klog.V(4).Infof("Failed to get auth secret %s: %v", ctrlcommon.InternalReleaseImageAuthSecretName, err) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller.go` around lines 348 - 349, When retrieving the auth secret with ctrl.secretLister.Secrets(...).Get(...), don't ignore the returned error; check the error and if it's non-nil and not a NotFound error (use apierrors.IsNotFound), log or return it so transient failures are visible. Locate the call that assigns iriAuthSecret (the Get against ctrlcommon.MCONamespace and ctrlcommon.InternalReleaseImageAuthSecretName) and add an error check: if err != nil && !apierrors.IsNotFound(err) then emit a descriptive log via the controller logger (or return the error) so RBAC/network issues are surfaced; keep treating NotFound as acceptable. Ensure you reference iriAuthSecret and the secretLister.Secrets(...) call when making this change.
502-508: Consider adding retry logic for pull secret update.Other updates in this controller use
retry.RetryOnConflict(e.g.,createOrUpdateMachineConfig,initializeInternalReleaseImageStatus). The global pull secret could be modified by other controllers concurrently, and a conflict would cause the entire sync to fail and requeue.♻️ Proposed fix
- pullSecret.Data[corev1.DockerConfigJsonKey] = mergedBytes - _, err = ctrl.kubeClient.CoreV1().Secrets(ctrlcommon.OpenshiftConfigNamespace).Update( - context.TODO(), pullSecret, metav1.UpdateOptions{}) - if err == nil { - klog.Infof("Updated pull secret with IRI registry auth credentials from secret %s/%s (uid=%s, resourceVersion=%s)", authSecret.Namespace, authSecret.Name, authSecret.UID, authSecret.ResourceVersion) - } - return err + return retry.RetryOnConflict(updateBackoff, func() error { + // Re-fetch to get latest resourceVersion on retry + pullSecret, err = ctrl.kubeClient.CoreV1().Secrets(ctrlcommon.OpenshiftConfigNamespace).Get( + context.TODO(), ctrlcommon.GlobalPullSecretName, metav1.GetOptions{}) + if err != nil { + return err + } + mergedBytes, err = MergeIRIAuthIntoPullSecret(pullSecret.Data[corev1.DockerConfigJsonKey], password, baseDomain) + if err != nil { + return err + } + if bytes.Equal(mergedBytes, pullSecret.Data[corev1.DockerConfigJsonKey]) { + return nil + } + pullSecret.Data[corev1.DockerConfigJsonKey] = mergedBytes + _, err = ctrl.kubeClient.CoreV1().Secrets(ctrlcommon.OpenshiftConfigNamespace).Update( + context.TODO(), pullSecret, metav1.UpdateOptions{}) + if err == nil { + klog.Infof("Updated pull secret with IRI registry auth credentials from secret %s/%s (uid=%s, resourceVersion=%s)", authSecret.Namespace, authSecret.Name, authSecret.UID, authSecret.ResourceVersion) + } + return err + })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller.go` around lines 502 - 508, Wrap the pull-secret update in a retry.RetryOnConflict loop similar to createOrUpdateMachineConfig/initializeInternalReleaseImageStatus: on conflict re-fetch the latest pullSecret via ctrl.kubeClient.CoreV1().Secrets(...).Get(...), re-apply the mergedBytes to pullSecret.Data[corev1.DockerConfigJsonKey], and call Update again until success or non-conflict error; preserve the existing klog.Infof on success and return the final error. Use the same metav1.UpdateOptions and context.TODO() already used so the logic integrates with the current Update call.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller.go`:
- Around line 348-349: When retrieving the auth secret with
ctrl.secretLister.Secrets(...).Get(...), don't ignore the returned error; check
the error and if it's non-nil and not a NotFound error (use
apierrors.IsNotFound), log or return it so transient failures are visible.
Locate the call that assigns iriAuthSecret (the Get against
ctrlcommon.MCONamespace and ctrlcommon.InternalReleaseImageAuthSecretName) and
add an error check: if err != nil && !apierrors.IsNotFound(err) then emit a
descriptive log via the controller logger (or return the error) so RBAC/network
issues are surfaced; keep treating NotFound as acceptable. Ensure you reference
iriAuthSecret and the secretLister.Secrets(...) call when making this change.
- Around line 502-508: Wrap the pull-secret update in a retry.RetryOnConflict
loop similar to
createOrUpdateMachineConfig/initializeInternalReleaseImageStatus: on conflict
re-fetch the latest pullSecret via
ctrl.kubeClient.CoreV1().Secrets(...).Get(...), re-apply the mergedBytes to
pullSecret.Data[corev1.DockerConfigJsonKey], and call Update again until success
or non-conflict error; preserve the existing klog.Infof on success and return
the final error. Use the same metav1.UpdateOptions and context.TODO() already
used so the logic integrates with the current Update call.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3249602d-1b91-4676-83e1-c7bccc52e7c7
📒 Files selected for processing (13)
pkg/controller/bootstrap/bootstrap.gopkg/controller/common/constants.gopkg/controller/internalreleaseimage/internalreleaseimage_bootstrap.gopkg/controller/internalreleaseimage/internalreleaseimage_bootstrap_test.gopkg/controller/internalreleaseimage/internalreleaseimage_controller.gopkg/controller/internalreleaseimage/internalreleaseimage_controller_test.gopkg/controller/internalreleaseimage/internalreleaseimage_helpers_test.gopkg/controller/internalreleaseimage/internalreleaseimage_renderer.gopkg/controller/internalreleaseimage/pullsecret.gopkg/controller/internalreleaseimage/pullsecret_test.gopkg/controller/internalreleaseimage/templates/master/files/iri-registry-auth-htpasswd.yamlpkg/controller/internalreleaseimage/templates/master/files/usr-local-bin-load-registry-image-sh.yamlpkg/controller/internalreleaseimage/templates/master/units/iri-registry.service.yaml
✅ Files skipped from review due to trivial changes (3)
- pkg/controller/internalreleaseimage/templates/master/files/iri-registry-auth-htpasswd.yaml
- pkg/controller/common/constants.go
- pkg/controller/internalreleaseimage/pullsecret_test.go
🚧 Files skipped from review as they are similar to previous changes (7)
- pkg/controller/internalreleaseimage/internalreleaseimage_bootstrap_test.go
- pkg/controller/internalreleaseimage/templates/master/files/usr-local-bin-load-registry-image-sh.yaml
- pkg/controller/internalreleaseimage/templates/master/units/iri-registry.service.yaml
- pkg/controller/internalreleaseimage/internalreleaseimage_bootstrap.go
- pkg/controller/internalreleaseimage/internalreleaseimage_renderer.go
- pkg/controller/internalreleaseimage/internalreleaseimage_helpers_test.go
- pkg/controller/bootstrap/bootstrap.go
|
/retest-required |
|
Depends on #5765 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkg/controller/internalreleaseimage/internalreleaseimage_controller_test.go`:
- Around line 84-94: In verifyPullSecret (the verifyPullSecret func in
internalreleaseimage_controller_test.go) replace the unchecked type assertion
auths := dockerConfig["auths"].(map[string]interface{}) and subsequent assert
calls with safe, checked type assertions using require for setup-critical
failures; specifically, use a type-assert-with-ok pattern for
dockerConfig["auths"] and for the iriEntry value (ensure iriEntry is a
map[string]interface{}), call require.NoError/require.True to fail fast on
parsing/type issues, then extract the "auth" (or expected credential field) from
the iriEntry map and assert its value equals the expected merged credential
string instead of only asserting presence. Ensure you reference
metav1.GetOptions, corev1.DockerConfigJsonKey, ctrlcommon.GlobalPullSecretName
and the verifyPullSecret function when making the changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9e61e77c-e707-441d-8f51-a1173916ef25
📒 Files selected for processing (6)
pkg/controller/bootstrap/bootstrap.gopkg/controller/internalreleaseimage/internalreleaseimage_bootstrap_test.gopkg/controller/internalreleaseimage/internalreleaseimage_controller.gopkg/controller/internalreleaseimage/internalreleaseimage_controller_test.gopkg/controller/internalreleaseimage/internalreleaseimage_helpers_test.gopkg/controller/internalreleaseimage/templates/master/files/usr-local-bin-load-registry-image-sh.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
- pkg/controller/internalreleaseimage/internalreleaseimage_bootstrap_test.go
- pkg/controller/internalreleaseimage/templates/master/files/usr-local-bin-load-registry-image-sh.yaml
- pkg/controller/bootstrap/bootstrap.go
- pkg/controller/internalreleaseimage/internalreleaseimage_controller.go
|
/retest-required |
|
/test ci/prow/e2e-gcp-op-ocl |
|
/lgtm |
|
Scheduling tests matching the |
|
The latest failure should in theory be fixed by openshift/release#78290 /retest-required |
|
/retest-required |
The template controller's WaitForCacheSync now includes iriInformerSynced
(InternalReleaseImages) and iriSecretsInformerSynced, but the
InternalReleaseImages CRD is only deployed on clusters where the
NoRegistryClusterInstall feature gate is enabled. On standard clusters
(gate off, no CRD), the reflector's LIST call fails immediately and
HasSynced() never returns true, permanently blocking the template
controller. This prevents the ControllerConfig status from being updated,
which deadlocks the render controller, leaving MCD stuck in bootstrap mode
and workers unable to join the cluster.
Fix: pass nil for both IRI informers when the gate is off (same pattern
used in cmd/machine-config-operator/start.go). The template controller
handles nil by substituting func() bool { return true } for the HasSynced
slots and skipping event handler registration.
Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
openshift-ci-robot
removed
the
verified
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
The CI failures were caused by a regression in this PR: the template controller's WaitForCacheSync now includes iriInformerSynced, but the InternalReleaseImages CRD doesn't exist on clusters where NoRegistryClusterInstall is disabled. The informer's LIST call fails immediately, HasSynced() never returns true, and the template controller is permanently blocked — it never updates ControllerConfig.Status.ObservedGeneration, which deadlocks the render controller, which leaves MCD stuck in bootstrap mode and workers unable to join. The last commit on this branch fixes it by gating the IRI informers on the feature flag (same pattern as cmd/machine-config-operator/start.go) and handling nil informers in template_controller.New() |
|
Interesting, I don't think we have a similar pattern necessarily but I think the changes should work /lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, rwsu, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rwsu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry job |
openshift-ci-robot
added
the
verified
|
@rwsu: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
TestRunInternalReleaseImageBootstrap_WithTLSProfile was missing the iriRegistryCredentialsSecret parameter after the rebase merged auth support from main (PR openshift#5765). The test was added in commit fa2b76b before auth was merged, so it had the old 4-parameter signature. During rebase, git didn't flag this as a conflict since the test didn't exist on main, resulting in a compile error. Fixes: pkg/controller/internalreleaseimage/internalreleaseimage_bootstrap_test.go:24:125: not enough arguments in call to RunInternalReleaseImageBootstrap Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>
The TLS profile e2e test and three unit tests were missing authentication credentials after the rebase merged auth support from main (PR openshift#5765). E2E test (test/e2e-iri/iri_test.go): - TestIRIController_VerifyTLSProfileEnforced Unit tests: - TestRunInternalReleaseImageBootstrap_WithTLSProfile - apply_Modern_TLS_profile_from_APIServer - cipher_suites_with_spaces_are_quoted_in_systemd_unit_to_prevent_word_splitting Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>
AGENT-1449: Add IRI registry authentication support to MCO
AGENT-1449: Add IRI registry authentication support to MCO
7 participants
*- What I did
Add htpasswd-based authentication to the IRI registry. The installer generates credentials and provides them via a bootstrap secret. The MCO mounts the htpasswd file into the registry container and configures registry auth environment variables. The registry password is merged into the node pull secret so kubelet can authenticate when pulling the release image.
- How to verify it
- Description for the changelog
Add htpasswd authentication to the Internal Release Image (IRI) registry. The registry now requires Basic Auth credentials, with the password stored in the internal-release-image-registry-auth secret and automatically merged into the global pull secret so kubelet can authenticate when pulling images. The master MachineConfig is updated to configure the registry's htpasswd file and enable auth environment variables in the systemd unit.