Skip to content

*: set kube-client-agent-image flag as required #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 19, 2019
Merged

*: set kube-client-agent-image flag as required #555

openshift-merge-robot merged 1 commit into from
Mar 19, 2019

Conversation

@hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Mar 15, 2019 •
edited
Loading

This PR is the final action to enable kube-client-agent to be part of the release payload.

depends on: openshift/installer#1429
ref: #538

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 15, 2019

/cc @runcom

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 15, 2019

failures expected will retest after installer PR merges

@runcom
Copy link
Member

runcom commented Mar 15, 2019

/approve

we'll merge after installer PR lands

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 15, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 15, 2019

/retest

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Mar 15, 2019 •
edited
Loading

For reference, PR : openshift/installer#1401 (required for this PR) has merged.

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 15, 2019

/joke

what week!

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 15, 2019

@hexfusion: What did one plate say to the other plate? Dinner is on me!

Details

In response to this:

/joke

what week!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 15, 2019

/test e2e-aws

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 15, 2019

/test e2e-aws-op

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 15, 2019

/retest

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 15, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 18, 2019

We are going to take another run at this today.

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 18, 2019

@kikisdeliveryservice just a heads up I am trying to push installer through now openshift/installer#1429

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 18, 2019

/retest

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 18, 2019

For reference, PR : openshift/installer#1429 (required for this PR) has merged.

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 18, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 18, 2019

/retest

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 18, 2019

/retest

/joke

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2019

@hexfusion: When my wife told me to stop impersonating a flamingo, I had to put my foot down.

Details

In response to this:

/retest

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 18, 2019

/test e2e-aws

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 19, 2019 •
edited
Loading

@runcom @kikisdeliveryservice if you are around this is finally passing :)!

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Mar 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ad18b8f into openshift:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@runcom runcom Awaiting requested review from runcom

Assignees

@kikisdeliveryservice kikisdeliveryservice

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hexfusion @runcom @kikisdeliveryservice @openshift-ci-robot @openshift-merge-robot