Fix MCD status reporting, retry loop and max unavailable progress #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
size/S
openshift-ci-robot
added
size/L
runcom
force-pushed
the
fix-mcd
branch
4 times, most recently
from
32420a9 to
8a44f15
Compare
runcom
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
This is good to be reviewed now and there's a self explanatory e2e test for rolling back a bad machineconfig. Just a note, this PR is a required follow up to the MCD rewrite as a controller. |
instead of polling for that long... Signed-off-by: Antonio Murdaca <[email protected]>
Since we're not just going to try again and again to apply a machineconfig, it makes little sense to have a global Degraded count in the MCP. Instead, base the logic on current vs desired config + state Done. This patch does that changing the logic but leaving most of it intact (I'd say the logic is now more robust and accounts for the new MCD as a controller model). Other than the above, with this patch you can finally, create a bad machineconfig and watch the daemon keep trying reconciling but failing (we can add the Unreconcilable annotation as a follow up indeed now), and just delete the bad machineconfig and everything goes back to the working, new, current state. I've also added e2e to cover most of what I've done here (for what is possible). Signed-off-by: Antonio Murdaca <[email protected]>
Member
Author
|
not related and known failure /retest |
Member
Author
|
openshift-sdn failing /retest |
Member
Author
|
green :) |
Member
Author
Member
|
Nice! /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca [email protected]
- What I did
This PR is a follow up from #548 which accounts for the change in behavior that we introduced with that. Most notably:
This PR includes #552 as well
so, close #552
- How to verify it
I'll add e2e(s) + the CI
- Description for the changelog