[release-4.20] OKD-294: Migrate runtime from runc to crun on an upgrade for OKD #5467
Conversation
Centos stream 10 dopped the runc package. For now OKD users are following the workaround to edit the MC to point to crun before the upgrade, but this should help with the migration rather than having to intervene manually. This PR: - checks for presence of the configmap - if MCO is built for OKD, edit the MC so the runtime is crun. - deletes the configmap
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OKD-294 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
/lgtm
/label backport-risk-assessed
Generally we only backport bugs, so I'm not sure if you can craft an OKD jira to fit the requirements. If not, you may have to open a dummy bug or ask someone with admin powers for an override
Also I dont think we should remove the code in 4.21. Probably 4.22 onwards is safest.
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
anuragthehatter,
eurijon,
imatza-rh,
lyman9966,
mhanss,
ptalgulk01,
rbbratta,
rioliu-rh and
sergiordlr
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Prashanth684
added
jira/valid-bug
|
/test okd-scos-e2e-aws-ovn |
|
/verified by @Prashanth684 |
openshift-ci-robot
added
the
verified
|
@Prashanth684: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 2a29ea4
into
openshift:release-4.20
13 participants
This is an automated cherry-pick of #5389
/assign Prashanth684