Skip to content

OCPBUGS-57364: Fix IP address for default AWS DNS resolver#5402

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
sadasu:aws-custom-dns
Nov 13, 2025
Merged

OCPBUGS-57364: Fix IP address for default AWS DNS resolver#5402
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
sadasu:aws-custom-dns

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Nov 10, 2025

When ClusterHostedDNS (or custom-dns) is enabled on AWS, the aws-update-dns service running on the control plane, was incorrectly setting 169.254.169.254 as the AWS default Nameserver.

Fixed this IP to 169.254.169.253 , based on Understanding Amazon DNS

@sadasu sadasu changed the title Aws custom dns OCPBUGS-57364: Fix IP address for default AWS DNS resolver Nov 10, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 10, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 10, 2025

@sadasu: This pull request references Jira Issue OCPBUGS-57364, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yunjiang29

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When ClusterHostedDNS (or custom-dns) is enabled on AWS, the aws-update-dns service running on the control plane, was incorrectly setting 169.254.169.254 as the AWS default Nameserver.

Fixed this IP to 169.254.169.253 , based on Understanding Amazon DNS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yunjiang29 November 10, 2025 17:29
@sadasu
AWS ClusterHostedDNS: Fix IP address for AWS DNS resolution
1aac42b 
The IP address for the Nameserver to be used as resolver for everything
other than API, API-Int and *.apps was incorrect. Fixed it based
on AWS documentation.
@sadasu
Copy link
Contributor Author

sadasu commented Nov 10, 2025

/retest-required

@gpei
Copy link

gpei commented Nov 11, 2025

/payload-job pull-ci-openshift-installer-main-e2e-aws-custom-dns-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

@gpei: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@gpei
Copy link

gpei commented Nov 11, 2025

/verified by @gpei

Reference job: https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/70591/rehearse-70591-periodic-ci-openshift-verification-tests-main-installer-rehearse-4.21-installer-rehearse-aws/1988229654103724032

The installation got passed with this PR, the DNS server on masters/workers is configured with node IP and Amazon DNS server

sh-5.1# cat /etc/resolv.conf 
# Generated by NetworkManager
nameserver 10.0.23.117
nameserver 169.254.169.253

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 11, 2025

@gpei: This PR has been marked as verified by @gpei.

Details

In response to this:

/verified by @gpei

Reference job: https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/70591/rehearse-70591-periodic-ci-openshift-verification-tests-main-installer-rehearse-4.21-installer-rehearse-aws/1988229654103724032

The installation got passed with this PR, the DNS server on masters/workers is configured with node IP and Amazon DNS server

sh-5.1# cat /etc/resolv.conf 
# Generated by NetworkManager
nameserver 10.0.23.117
nameserver 169.254.169.253

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo
tthvo reviewed Nov 11, 2025
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@sadasu
Copy link
Contributor Author

sadasu commented Nov 12, 2025

/retest

@jhixson74
Copy link
Member

jhixson74 commented Nov 12, 2025

/lgtm

isabella-janssen
isabella-janssen reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Approving based on the information in the provided reference article.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, jhixson74, sadasu, tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025

/retest-required

Remaining retests: 0 against base HEAD 5c30302 and 2 for PR HEAD 1aac42b in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2025

/retest-required

Remaining retests: 0 against base HEAD 455d5c3 and 1 for PR HEAD 1aac42b in total

@tthvo
Copy link
Member

tthvo commented Nov 13, 2025

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2025

/retest-required

Remaining retests: 0 against base HEAD 7c04bdb and 0 for PR HEAD 1aac42b in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2025

/hold

Revision 1aac42b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@sadasu
Copy link
Contributor Author

sadasu commented Nov 13, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2025

/retest-required

Remaining retests: 0 against base HEAD eeabc73 and 2 for PR HEAD 1aac42b in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

@sadasu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ca0c19d into openshift:main Nov 13, 2025
15 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2025

@sadasu: Jira Issue OCPBUGS-57364: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-57364 has been moved to the MODIFIED state.

Details

In response to this:

When ClusterHostedDNS (or custom-dns) is enabled on AWS, the aws-update-dns service running on the control plane, was incorrectly setting 169.254.169.254 as the AWS default Nameserver.

Fixed this IP to 169.254.169.253 , based on Understanding Amazon DNS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 20, 2025

Fix included in accepted release 4.21.0-0.nightly-2025-11-15-144034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

@yunjiang29 yunjiang29 Awaiting requested review from yunjiang29

2 more reviewers

@tthvo tthvo tthvo left review comments

@isabella-janssen isabella-janssen isabella-janssen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jhixson74 jhixson74

@tthvo tthvo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sadasu @openshift-ci-robot @gpei @jhixson74 @tthvo @openshift-merge-robot @isabella-janssen