OCPBUGS-58023: Prevent unnecessary systemd unit disable; Revert TRT-2232 #5225
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@RishabhSaini: This pull request references TRT-2232 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
RishabhSaini
force-pushed
the
revert-5213-revert-5148-1754043225154
branch
3 times, most recently
from
5aca015 to
cf1747a
Compare
helpers: Compute systemdUnits that added and changed between Ign configs update: Only write added or updated systemd units on_disk_validation: Check if systemd units in config enabled correctly
RishabhSaini
force-pushed
the
revert-5213-revert-5148-1754043225154
branch
from
cf1747a to
40304eb
Compare
|
/test e2e-agnostic-ovn |
|
@RishabhSaini: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-azure-ovn-upgrade |
|
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
/lgtm
Should we also run payload tests just in case? Although it does look like both Azure and Metal did install correctly in this case.
| out := strings.TrimSpace(string(outBytes)) | ||
|
|
||
| switch { | ||
| case *expectedEnabled: |
There was a problem hiding this comment.
For future cases, per openshift guidance, the fix should be a separate commit to make it easier to see the fix vs the unrevert.
In this case the nuanced states makes sense to me
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RishabhSaini, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle OCPBUGS-58023: Prevent unnecessary systemd unit disable; Revert TRT-2232 |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@RishabhSaini: This pull request references Jira Issue OCPBUGS-58023, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-58023, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
Reverts #5213