-
Notifications
You must be signed in to change notification settings - Fork 462
[release-4.19] OCPBUGS-59208: Backport QE ported test for OCL component readiness #5125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.19] OCPBUGS-59208: Backport QE ported test for OCL component readiness #5125
Conversation
|
@pablintino: This pull request references MCO-1739 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
db094ba to
3d73655
Compare
3d73655 to
1ead6a6
Compare
yuqi-zhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label backport-risk-assessed
Didn't check the exact diff but the overall changes lgtm. Should be safe to merge since it doesn't otherwise affect MCO functionality
|
Due to this being a backport, looks like it requires a valid bug or an override by someone with override powers. Would you like to open a dummy backport bug or should we reach out for the override? |
1ead6a6 to
1832dab
Compare
|
@pablintino: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira-refresh |
|
@pablintino: This pull request references Jira Issue OCPBUGS-59208, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pablintino: This pull request references Jira Issue OCPBUGS-59208, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pablintino: This pull request references Jira Issue OCPBUGS-59208, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira-refresh |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1fb7035
into
openshift:release-4.19
|
@pablintino: Jira Issue OCPBUGS-59208: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-59208 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
This PR is a manual backport of #5108
This changes moves/copies the extended QE test suites to our repo to be consumed by upstream CI for OCL component readiness.
The ported code is the bare minimum required to run the selected tests (choosen by this spike). The code has been also updated to match the Golang capabilities our version has, to align it with our linting rules and to try to minimize the amount of external dependencies.
Spin up a 4.19 cluster
Run the new added command machine-config-tests-ext run-suite openshift/machine-config-operator/disruptive
Ensure the tests in the MCO-1651 spike are listed and pass.
This change integrates a minimal, updated subset of the extended MCO QE test suites into the repository to enable upstream CI validation for the OCL component.