Skip to content

Conversation

@pablintino
Copy link
Contributor

This PR is a manual backport of #5108

  • What I did

This changes moves/copies the extended QE test suites to our repo to be consumed by upstream CI for OCL component readiness.
The ported code is the bare minimum required to run the selected tests (choosen by this spike). The code has been also updated to match the Golang capabilities our version has, to align it with our linting rules and to try to minimize the amount of external dependencies.

  • How to verify it

Spin up a 4.19 cluster
Run the new added command machine-config-tests-ext run-suite openshift/machine-config-operator/disruptive
Ensure the tests in the MCO-1651 spike are listed and pass.

  • Description for the changelog

This change integrates a minimal, updated subset of the extended MCO QE test suites into the repository to enable upstream CI validation for the OCL component.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 17, 2025

@pablintino: This pull request references MCO-1739 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This PR is a manual backport of #5108

  • What I did

This changes moves/copies the extended QE test suites to our repo to be consumed by upstream CI for OCL component readiness.
The ported code is the bare minimum required to run the selected tests (choosen by this spike). The code has been also updated to match the Golang capabilities our version has, to align it with our linting rules and to try to minimize the amount of external dependencies.

  • How to verify it

Spin up a 4.19 cluster
Run the new added command machine-config-tests-ext run-suite openshift/machine-config-operator/disruptive
Ensure the tests in the MCO-1651 spike are listed and pass.

  • Description for the changelog

This change integrates a minimal, updated subset of the extended MCO QE test suites into the repository to enable upstream CI validation for the OCL component.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2025
@pablintino pablintino force-pushed the mco-qe-testsuite-port-4-19 branch 2 times, most recently from db094ba to 3d73655 Compare July 2, 2025 15:51
@pablintino pablintino force-pushed the mco-qe-testsuite-port-4-19 branch from 3d73655 to 1ead6a6 Compare July 7, 2025 14:34
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

Didn't check the exact diff but the overall changes lgtm. Should be safe to merge since it doesn't otherwise affect MCO functionality

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 7, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@yuqi-zhang
Copy link
Contributor

Due to this being a backport, looks like it requires a valid bug or an override by someone with override powers. Would you like to open a dummy backport bug or should we reach out for the override?

@pablintino pablintino force-pushed the mco-qe-testsuite-port-4-19 branch from 1ead6a6 to 1832dab Compare July 9, 2025 15:50
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 1832dab link false /test e2e-openstack
ci/prow/e2e-azure-ovn-upgrade-out-of-change 1832dab link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-vsphere-ovn-upi-zones 1832dab link false /test e2e-vsphere-ovn-upi-zones

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pablintino
Copy link
Contributor Author

/jira-refresh

@pablintino pablintino changed the title [release-4.19] MCO-1739: Backport QE ported test for OCL component readiness [release-4.19] OCPBUGS-59208: Backport QE ported test for OCL component readiness Jul 10, 2025
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 10, 2025
@openshift-ci-robot
Copy link
Contributor

@pablintino: This pull request references Jira Issue OCPBUGS-59208, which is invalid:

  • expected the bug to target the "4.19.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-59208 to depend on a bug targeting a version in 4.20.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR is a manual backport of #5108

  • What I did

This changes moves/copies the extended QE test suites to our repo to be consumed by upstream CI for OCL component readiness.
The ported code is the bare minimum required to run the selected tests (choosen by this spike). The code has been also updated to match the Golang capabilities our version has, to align it with our linting rules and to try to minimize the amount of external dependencies.

  • How to verify it

Spin up a 4.19 cluster
Run the new added command machine-config-tests-ext run-suite openshift/machine-config-operator/disruptive
Ensure the tests in the MCO-1651 spike are listed and pass.

  • Description for the changelog

This change integrates a minimal, updated subset of the extended MCO QE test suites into the repository to enable upstream CI validation for the OCL component.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@pablintino: This pull request references Jira Issue OCPBUGS-59208, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.20.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-59208 to depend on a bug targeting a version in 4.20.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 10, 2025
@openshift-ci-robot
Copy link
Contributor

@pablintino: This pull request references Jira Issue OCPBUGS-59208, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-59210 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-59210 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 10, 2025
@pablintino
Copy link
Contributor Author

/jira-refresh

@yuqi-zhang
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [pablintino,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1fb7035 into openshift:release-4.19 Jul 10, 2025
20 of 23 checks passed
@openshift-ci-robot
Copy link
Contributor

@pablintino: Jira Issue OCPBUGS-59208: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-59208 has not been moved to the MODIFIED state.

Details

In response to this:

This PR is a manual backport of #5108

  • What I did

This changes moves/copies the extended QE test suites to our repo to be consumed by upstream CI for OCL component readiness.
The ported code is the bare minimum required to run the selected tests (choosen by this spike). The code has been also updated to match the Golang capabilities our version has, to align it with our linting rules and to try to minimize the amount of external dependencies.

  • How to verify it

Spin up a 4.19 cluster
Run the new added command machine-config-tests-ext run-suite openshift/machine-config-operator/disruptive
Ensure the tests in the MCO-1651 spike are listed and pass.

  • Description for the changelog

This change integrates a minimal, updated subset of the extended MCO QE test suites into the repository to enable upstream CI validation for the OCL component.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202507101836.p0.g1fb7035.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.