Skip to content

OCPBUGS-57135: pkg/operator/status: Drop PoolUpdating as an Upgradeable=False condition #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 11, 2025
Merged

OCPBUGS-57135: pkg/operator/status: Drop PoolUpdating as an Upgradeable=False condition #5111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions pkg/operator/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,13 +304,6 @@ func (optr *Operator) syncUpgradeableStatus(co *configv1.ClusterOperator) error
break
}
}
// this should no longer trigger when adding a node to a pool. It should only trigger if the node actually has to go through an upgrade
// updating and degraded can occur together, in that case defer to the degraded Reason that is already set above
if updating && !degraded && !interrupted {
coStatusCondition.Status = configv1.ConditionFalse
coStatusCondition.Reason = "PoolUpdating"
coStatusCondition.Message = "One or more machine config pools are updating, please see `oc get mcp` for further details"
}

// don't overwrite status if updating or degraded
if !updating && !degraded && !interrupted {
Expand Down