Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented Feb 24, 2019

- What I did

The code wasn't honoring the versionCheckRequired for checking sub-MCs in pools. The main MC for the pool must be correctly generated by the correct controller version, that shouldn't be true for sub MCs?

Ref: #487

side note: we should also land #385 somehow

- How to verify it

- Description for the changelog

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2019
@openshift-ci-robot
Copy link
Contributor

@runcom: The following test failed for commit f578f1b, say /retest to rerun them:

Test name Details Rerun command
ci/prow/unit link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom runcom closed this Feb 24, 2019
@runcom runcom deleted the crc-race branch February 24, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants