Skip to content

OCPBUGS-38292: Revert "controller: default to runc when upgrading clusters from 4.17 to 4.18" #4716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 23, 2024
Merged

OCPBUGS-38292: Revert "controller: default to runc when upgrading clusters from 4.17 to 4.18" #4716

openshift-merge-bot merged 1 commit into from
Nov 23, 2024

Conversation

@sohankunkerkar
Copy link
Member

@sohankunkerkar sohankunkerkar commented Nov 22, 2024

This reverts commit fd14857, reversing changes made to 39e1cd3.
The default MC takes precedence over the ContainerRuntimeConfig, meaning anyone upgrading to the new 4.17 will revert to runc until they notice and delete the newly created defaulting MC.

- What I did

- How to verify it

- Description for the changelog

@sohankunkerkar
Revert "Merge pull request openshift#4635 from sohankunkerkar/default…
57e60ff 
…-runc"

This reverts commit fd14857, reversing
changes made to 39e1cd3.
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 22, 2024

@sohankunkerkar: This pull request references Jira Issue OCPBUGS-38292, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-38292 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit fd14857, reversing changes made to 39e1cd3.
The default MC takes precedence over the ContainerRuntimeConfig, meaning anyone upgrading to the new 4.17 will revert to runc until they notice and delete the newly created defaulting MC.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wking
Copy link
Member

wking commented Nov 22, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 22, 2024

@wking: This pull request references Jira Issue OCPBUGS-38292, which is invalid:

  • expected Jira Issue OCPBUGS-38292 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yuqi-zhang
yuqi-zhang approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@mrunalp mrunalp added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 22, 2024
@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 22, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, sohankunkerkar, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Nov 22, 2024
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 22, 2024

/retest-required

Remaining retests: 0 against base HEAD fd14857 and 2 for PR HEAD 57e60ff in total

@sohankunkerkar
Copy link
Member Author

sohankunkerkar commented Nov 23, 2024

/retest

@sohankunkerkar
Copy link
Member Author

sohankunkerkar commented Nov 23, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit f5d2289 into openshift:release-4.17 Nov 23, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 23, 2024

@sohankunkerkar: Jira Issue OCPBUGS-38292: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38292 has been moved to the MODIFIED state.

Details

In response to this:

This reverts commit fd14857, reversing changes made to 39e1cd3.
The default MC takes precedence over the ContainerRuntimeConfig, meaning anyone upgrading to the new 4.17 will revert to runc until they notice and delete the newly created defaulting MC.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2024

@sohankunkerkar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview 57e60ff link false /test e2e-gcp-op-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.17.0-202411231835.p0.gf5d2289.assembly.stream.el9.
All builds following this will include this PR.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@mtrmac mtrmac Awaiting requested review from mtrmac

Assignees

@rbbratta rbbratta

@eurijon eurijon

@mburman5 mburman5

@reihl reihl

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.