Skip to content

[release-4.16] OCPBUGS-41806: When newly built images rolled out, the update progress is not displaying correctly (went 0 --> 3) #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Sep 16, 2024
Merged

[release-4.16] OCPBUGS-41806: When newly built images rolled out, the update progress is not displaying correctly (went 0 --> 3) #4584

openshift-merge-bot merged 2 commits into from
Sep 16, 2024

Conversation

@djoshy
Copy link
Contributor

@djoshy djoshy commented Sep 11, 2024

Manual cherry pick of #4583

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2024

@djoshy: This pull request references Jira Issue OCPBUGS-41806, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.0" instead
  • expected Jira Issue OCPBUGS-41806 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry pick of #4583

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 11, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@sergiordlr
Copy link
Contributor

sergiordlr commented Sep 12, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 12, 2024
@djoshy
Copy link
Contributor Author

djoshy commented Sep 16, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 16, 2024

@djoshy: This pull request references Jira Issue OCPBUGS-41806, which is invalid:

  • expected Jira Issue OCPBUGS-41806 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor Author

djoshy commented Sep 16, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 16, 2024

@djoshy: This pull request references Jira Issue OCPBUGS-41806, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-41802 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-41802 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr September 16, 2024 13:19
@djoshy
Copy link
Contributor Author

djoshy commented Sep 16, 2024

/retest-required

1 similar comment
@djoshy
Copy link
Contributor Author

djoshy commented Sep 16, 2024

/retest-required

yuqi-zhang
yuqi-zhang approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

clean backport

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 16, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 16, 2024

/retest-required

Remaining retests: 0 against base HEAD 0cf3960 and 2 for PR HEAD f9b96b3 in total

@djoshy
Copy link
Contributor Author

djoshy commented Sep 16, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview f9b96b3 link false /test e2e-gcp-op-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6a425ab into openshift:release-4.16 Sep 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 16, 2024

@djoshy: Jira Issue OCPBUGS-41806: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41806 has been moved to the MODIFIED state.

Details

In response to this:

Manual cherry pick of #4583

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 16, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.16.0-202409162206.p0.g6a425ab.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Sep 17, 2024

Fix included in accepted release 4.16.0-0.nightly-2024-09-17-060556

@djoshy djoshy deleted the 4.16-ocl-status branch September 24, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@jkyros jkyros Awaiting requested review from jkyros

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@rbbratta rbbratta

@eurijon eurijon

@mburman5 mburman5

@reihl reihl

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.