MCO-1214: Enabled boot images updates for AWS #4492
Conversation
|
@CourtCourt521: This pull request references MCO-1214 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
generally looks good! some comments inline
|
Verified using automated test cases for GCP (adapted to use AWS). Automation has been adapted to support AWS (WIP still) https://github.com/openshift/openshift-tests-private/pull/18630 All test cases passed in AWS: "[sig-mco] MCO Bootimages Author:sregidor-NonHyperShiftHOST-NonPreRelease-Medium-74238-BootImages not updated by default [Disruptive] [Serial]" In a GCP cluster those test cases passed too. /label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@CourtCourt521: This pull request references MCO-1214 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Points addressed and ready for another review! |
CourtCourt521
force-pushed
the
MCO-boot-Images
branch
2 times, most recently
from
0919dad to
bb41500
Compare
CourtCourt521
force-pushed
the
MCO-boot-Images
branch
from
bb41500 to
3bb751a
Compare
|
/test all |
|
/retitle MCO-1214: Enabled boot images updates for AWS |
openshift-ci
bot
changed the title
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
/lgtm
changes looks good to me, thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CourtCourt521, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
1 similar comment
|
/retest-required |
|
/override ci/prow/e2e-hypershift Overriding as it has passed this test before and it is behind feature gate. |
|
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@CourtCourt521: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
6 participants
- What I did
I enabled the ManagedBootImage feature for the AWS platform as part of managing boot images via the MCO
- How to verify it
See the instructions in this PR for testing GCP for setting up the cluster.
#4083
Please note that with AWS instead of directly using one boot image for each cluster version like GCP does. AWS uses a specific boot image per region for each version and they are stored in the ami field
You can see each region and the value assigned to that ami in the coreos-bootimages configmap in the machine-config-operator namespace for validation that it's correct.