Skip to content

Conversation

@smarterclayton
Copy link
Contributor

As part of the general cleanup we are moving to UBI based Docker images
and util-linux is being removed from the base image. Add an explicit
dependency here.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2019
…base

As part of the general cleanup we are moving to UBI based Docker images
and util-linux is being removed from the base image. Add an explicit
dependency here.
@runcom
Copy link
Member

runcom commented Feb 16, 2019

/approve

@runcom
Copy link
Member

runcom commented Feb 16, 2019

not sure why rhel-images job isn't running (also on other PRs)

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [runcom,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor Author

rhel-images was removed, but something is wrong with the status. Assuming this goes green I'm going to force merge (I'm still trying to debug why the status came back)

@smarterclayton
Copy link
Contributor Author

/refresh

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2019
@openshift-merge-robot openshift-merge-robot merged commit 758fcc0 into openshift:master Feb 17, 2019
@hexfusion
Copy link
Contributor

@smarterclayton if I try make image-daemon build fails for Dockerfile.machine-config-daemon is this rhel only?

[....]
STEP 11: RUN yum install -y util-linux && yum clean all && rm -rf /var/cache/yum/*
Loaded plugins: ovl, product-id, search-disabled-repos, subscription-manager
This system is not registered with an entitlement server. You can use subscription-manager to register.
http://base-4-0.ocp.svc/rhel-fast-datapath/repodata/repomd.xml: [Errno 14] curl#6 - "Could not resolve host: base-4-0.ocp.svc; Unknown error"
Trying other mirror.

/cc @abhinavdahiya

@hexfusion
Copy link
Contributor

ref: #463

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Feb 20, 2019 via email

@runcom
Copy link
Member

runcom commented Feb 21, 2019

Yes, for right now you have to be building the dockerfile on the ci environment. We’re going to have a workaround for that soon but it’s complicated by not wanting to share our certificates too broadly.

@smarterclayton this breaks our own local development since we build images locally and deploy them on a running cluster to iterate on changes

(you need to remove the cached image and repull though docker|podman rmi -f registry.svc.ci.openshift.org/openshift/origin-v4.0:base and run make images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants