OCPNODE-2336: Drop ClusterImagePolicy validation on scope conflicts with release-image repo #4401
Conversation
|
@QiWang19: This pull request references OCPNODE-2336 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
…ith release-image repo Remove the restriction on setting policy for release payload repository to not block the implementation for openshift/enhancements#1633 Signed-off-by: Qi Wang <[email protected]>
QiWang19
force-pushed
the
drop-validation
branch
from
ec449bf to
829684e
Compare
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@mtrmac PTAL |
|
/assign @djoshy |
|
@QiWang19: GitHub didn't allow me to assign the following users: assign. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Locally code LGTM; IIRC there should also be some change of the API documentation?
saschagrunert
left a comment
saschagrunert
left a comment
There was a problem hiding this comment.
/lgtm
API docs are tracked in https://issues.redhat.com/browse/OCPNODE-2358
|
/assign @yuqi-zhang |
|
Avoid eliding the pull title, because this gets included in release-controller diffs and such: /retitle OCPNODE-2336: Drop ClusterImagePolicy validation on scope conflicts with release-image repo |
openshift-ci
bot
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: QiWang19, saschagrunert, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-config-operator-container-v4.17.0-202406120610.p0.geafd0ba.assembly.stream.el9 for distgit ose-machine-config-operator. |
7 participants
…ith release-image repo
Remove the restriction on setting policy for release payload repository to not block the implementation for openshift/enhancements#1633
- What I did
- How to verify it
- Description for the changelog