Skip to content

kubeletconfig: fix updates, add unit test, race condition fix #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 16, 2019
Merged

kubeletconfig: fix updates, add unit test, race condition fix #437

openshift-merge-robot merged 2 commits into from
Feb 16, 2019

Conversation

@rphillips
Copy link
Contributor

@rphillips rphillips commented Feb 15, 2019 •
edited
Loading

- What I did

@umohnani8 found a bug in kubeletconfig updates. This PR adds a unit test and fixes the underlying validation.

- How to verify it

Unit test

- Description for the changelog

Fix KubeletConfig updates not being applied correctly to the MachineConfig.

Also fixes race conditions found in:
Close #417

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 15, 2019
@runcom
Copy link
Member

runcom commented Feb 15, 2019

/approve

/cc @sjenning

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@rphillips
Copy link
Contributor Author

rphillips commented Feb 15, 2019

odd... failure in a different test.

@runcom
Copy link
Member

runcom commented Feb 15, 2019

That's known #417

@rphillips
Copy link
Contributor Author

rphillips commented Feb 15, 2019

/retest

I'll take a look at the flaky test

@rphillips rphillips force-pushed the fixes/fix_for_update_kubelet_configs branch 2 times, most recently from 18fbafe to f36769d Compare February 15, 2019 18:16
@runcom
Copy link
Member

runcom commented Feb 15, 2019

@rphillips thanks for the flake test fixes ❤️ could you add "close #417" to the first comment as well?

@rphillips
Copy link
Contributor Author

rphillips commented Feb 15, 2019

go test -race is nice. The two test controllers seem to be using the same k8s cache. Hopefully this clears it up fully.

@rphillips rphillips force-pushed the fixes/fix_for_update_kubelet_configs branch from f36769d to 57ff65d Compare February 15, 2019 18:22
@runcom
Copy link
Member

runcom commented Feb 15, 2019

/retest

@rphillips rphillips changed the title kubeletconfig: fix updates and add unit test kubeletconfig: fix updates, add unit test, race condition fix Feb 15, 2019
@runcom
Copy link
Member

runcom commented Feb 15, 2019

/retest

3 similar comments
@runcom
Copy link
Member

runcom commented Feb 15, 2019

/retest

@runcom
Copy link
Member

runcom commented Feb 15, 2019

/retest

@runcom
Copy link
Member

runcom commented Feb 15, 2019

/retest

@runcom
Copy link
Member

runcom commented Feb 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@ashcrow
Copy link
Member

ashcrow commented Feb 16, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@runcom runcom mentioned this pull request Feb 16, 2019
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 745693c into openshift:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@runcom runcom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestKubeletConfigCreate flake?

6 participants

@rphillips @runcom @openshift-ci-robot @openshift-bot @ashcrow @openshift-merge-robot