pkg/controller: add osimageurl to base ssh MC as well #435
Conversation
This reverts commit 3808104 - it didn't work and actively breaks things actually because we no long substitute the value at build time.
This injects the `OSImageURL` into the "base" config (e.g. `00-worker`, `00-master`). This differs from previous pull requests which made it a separate MC, but that adds visual noise and will exacerbate renderer race conditions.
Signed-off-by: Antonio Murdaca <[email protected]>
openshift-ci-robot
added
the
size/M
|
This isn't necessary and IMO will just add confusion. See #228 for some history around this. If I could go back in time I think we should have made |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
openshift-ci-robot
requested review from
abhinavdahiya and
kikisdeliveryservice
|
Specifically see #279 |
|
makes total sense, closing, thanks for looking |
|
@runcom: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
- What I did
builds on top of #363, cause I don't want to block that from merging right now, if you guys want instead, I'll close this and, assuming this is needed we'll modify #363 directly.
@cgwalters ptal I'm not entirely sure we need this but I saw the ssh MCs were missing the osimageurl so I've added it (check only last commit)
- How I did it
vim
- How to verify it
test this PR with a custom payload and verify the
-sshMCs do have the osimageurl populated as well- Description for the changelog