MCO-1129: Re-land Adapting the MCO featuregate usage to new API #4315
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
|
/payload 4.16 ci blocking |
|
@djoshy: trigger 5 job(s) of type blocking for the ci release of OCP 4.16
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e0ee3640-f83f-11ee-99a2-a9380ec5c823-0 |
|
/test e2e-gcp-op |
djoshy
force-pushed
the
api-bump-debug
branch
2 times, most recently
from
00d3b4e to
02d623e
Compare
…aturegate usage to new API""
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
djoshy
changed the title
|
@djoshy: This pull request references MCO-1129 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/payload 4.16 ci blocking |
|
@djoshy: trigger 5 job(s) of type blocking for the ci release of OCP 4.16
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6c19fc80-f8dc-11ee-8ae8-1b5348fa1c4a-0 |
|
@djoshy: This pull request references MCO-1129 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This commit updates the hack script to reflect the new home of the MCO API in openshift/api. Some install manifests have been renamed to be consistent. It also removes syncCustomResourceDefinitions which is no longer needed.
|
|
||
| //nolint:gocyclo | ||
| func (optr *Operator) syncRenderConfig(_ *renderConfig) error { | ||
| if err := optr.syncCustomResourceDefinitions(); err != nil { |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ci/prow/okd-scos-e2e-aws-ovn |
|
@hexfusion: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test okd-scos-e2e-aws-ovn |
|
/test e2e-hypershift |
|
@djoshy: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-config-operator-container-v4.16.0-202404130215.p0.g509a97d.assembly.stream.el9 for distgit ose-machine-config-operator. |
catch up with MCO openshift/machine-config-operator#4315 Signed-off-by: Francesco Romani <fromani@redhat.com>
catch up with MCO openshift/machine-config-operator#4315 Signed-off-by: Francesco Romani <fromani@redhat.com>
catch up with MCO openshift/machine-config-operator#4315 Signed-off-by: Francesco Romani <fromani@redhat.com>
6 participants
This PR includes:
syncCustomResourceDefinitionsas we don't need this locally anymore